ColorPicker: Fix app crash when clearing input fields #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
StephenLPeters
added
area-ColorPicker
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Felix-Dev
deleted the
user/Felix-Dev/colorpicker-clearinginputfields-crash-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an app crash when clearing either the hex- or alpha channel input field of the ColorPicker.
Note: While the linked issue only mentions an app crash occuring when clearing the hex input field, looking further into the ColorPicker implementation, I noticed that clearing the alpha channel also wasn't specifically guarded against, resulting in an app crash as well. I've added the required check for that in this PR as well.
Motivation and Context
Fixes #3222.
How Has This Been Tested?
Tested manually and added API tests.