Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More InfoBarPanel API udpates #3739

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Conversation

ranjeshj
Copy link
Contributor

@ranjeshj ranjeshj commented Dec 2, 2020

Updating the API to match API spec one more time. Update naming, and don't ignore some of the values in padding/margins.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 2, 2020
@ranjeshj ranjeshj added area-InfoBar team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Dec 2, 2020
@ranjeshj
Copy link
Contributor Author

ranjeshj commented Dec 2, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

dev/InfoBar/InfoBarPanel.cpp Outdated Show resolved Hide resolved
dev/InfoBar/InfoBarPanel.cpp Outdated Show resolved Hide resolved
@ranjeshj
Copy link
Contributor Author

ranjeshj commented Dec 2, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit 533c6b1 into master Dec 3, 2020
@ranjeshj ranjeshj deleted the user/ranjeshj/InfoBarPanelAPI branch December 3, 2020 00:49
ranjeshj added a commit that referenced this pull request Dec 3, 2020
* update API names

* update to use all the padding/margin properties

* Update for PR comments.

Co-authored-by: Tammy Paine <30241445+teaP@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-InfoBar team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants