-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert some changes to ListBox resources to have selected state be visible #3892
Merged
ranjeshj
merged 1 commit into
microsoft:master
from
marcelwgn:user/chingucoding/revert-comboboxchanges
Jan 11, 2021
Merged
Revert some changes to ListBox resources to have selected state be visible #3892
ranjeshj
merged 1 commit into
microsoft:master
from
marcelwgn:user/chingucoding/revert-comboboxchanges
Jan 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
team-Controls
Issue for the Controls team
and removed
needs-triage
Issue needs to be triaged by the area owners
labels
Jan 5, 2021
I'm not sure if there are other colors that are going to have incorrect contrast ratio. If fixing just these makes everything meet contrast ratio, then we should be good. I'll let @YuliKl make the call. |
@chingucoding Can you move to master ? we merged the changes into master now. |
marcelwgn
force-pushed
the
user/chingucoding/revert-comboboxchanges
branch
from
January 8, 2021 22:52
a5e2189
to
bf2a77f
Compare
This PR now targets master and is up to date. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
approved these changes
Jan 11, 2021
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jul 9, 2022
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert some resource changes to make the selected item of the ListBox visible.
Few notes:
Motivation and Context
Closes #3808
How Has This Been Tested?
Tested manually:
Screenshots (if appropriate):