Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some changes to ListBox resources to have selected state be visible #3892

Merged

Conversation

marcelwgn
Copy link
Contributor

Description

Revert some resource changes to make the selected item of the ListBox visible.

Few notes:

  • Added cert and pfx file as otherwise test app won't compile anymore due to expired certificates
  • This is not a hard reset of changes but rather an update of few brushes to get the desired behavior back while also keeping current XAML design

Motivation and Context

Closes #3808

How Has This Been Tested?

Tested manually:
Gif showing listbox selection hover states

Screenshots (if appropriate):

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 5, 2021
@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 5, 2021

/azp run

@ranjeshj ranjeshj added the area-UIDesign UI Design, styling label Jan 5, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jan 5, 2021
@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 6, 2021

I'm not sure if there are other colors that are going to have incorrect contrast ratio. If fixing just these makes everything meet contrast ratio, then we should be good. I'll let @YuliKl make the call.

@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 8, 2021

@chingucoding Can you move to master ? we merged the changes into master now.

@marcelwgn marcelwgn changed the base branch from feature/token-experiment to master January 8, 2021 22:08
@marcelwgn marcelwgn force-pushed the user/chingucoding/revert-comboboxchanges branch from a5e2189 to bf2a77f Compare January 8, 2021 22:52
@marcelwgn
Copy link
Contributor Author

This PR now targets master and is up to date.

@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

I'm not sure if there are other colors that are going to have incorrect contrast ratio. If fixing just these makes everything meet contrast ratio, then we should be good. I'll let @YuliKl make the call.

@YuliKl Lets take this fix. If there are more bugs that come up, we can re-evaluate a rollback.

@ranjeshj ranjeshj merged commit 3b48922 into microsoft:master Jan 11, 2021
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 9, 2022
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert color changes for ListBox
2 participants