Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout review and changes #3936

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Flyout review and changes #3936

merged 4 commits into from
Jan 14, 2021

Conversation

tashatitova
Copy link
Contributor

  • Moving static resources from theme to static
  • Removing extra resources
  • Updating HC resources to correct brushes and stroke width (2 in HC)

Padding (of default 0) seemed to have been set twice, so actually moving it to template binding padding on outer border.

This is an empty container flyout - a lightweight control with no additional content.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 13, 2021
@StephenLPeters StephenLPeters added area-Flyouts area-Styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jan 13, 2021
@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova tashatitova merged commit 574dc96 into master Jan 14, 2021
@tashatitova tashatitova deleted the user/tatito/flyout branch January 14, 2021 21:37
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 10, 2022
@Kinnara
Port microsoft/microsoft-ui-xaml#3936
1d9ec1d
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 10, 2022
@Kinnara
Port microsoft/microsoft-ui-xaml#3936 (#480)
f28f50c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtauk mdtauk mdtauk left review comments

@karkarl karkarl karkarl left review comments

@marksfoster marksfoster marksfoster approved these changes

@StephenLPeters StephenLPeters Awaiting requested review from StephenLPeters

@YuliKl YuliKl Awaiting requested review from YuliKl

@teaP teaP Awaiting requested review from teaP

Assignees
No one assigned
Labels
area-Flyouts area-Styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tashatitova @mdtauk @karkarl @marksfoster @StephenLPeters