Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fluent icons new codepoints for datepicker, timepicker, flipview, scrollbar, pipspage #4129

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Use fluent icons new codepoints for datepicker, timepicker, flipview, scrollbar, pipspage #4129

merged 5 commits into from
Feb 17, 2021

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented Feb 8, 2021 •
edited
Loading

  1. Use fluent icons new codepoints for datepicker, timepicker, flipview, scrollbar, pipspage
  2. Add RequireInsiderSDK to support 21h1 fonts to compiled even if there is no 21h1 insderSDK

CalendarView:
image

LoopSelector for datepicker and timepicker:
image

image

FlipView
image
image

Scrollbar:
image
image
image
image

PipsPager
image
image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 8, 2021
@StephenLPeters StephenLPeters added area-Styling area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Feb 9, 2021
@licanhua
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@licanhua licanhua changed the title User/canli/fonts Use fluent icons new codepoints for datepicker, timepicker, flipview, scrollbar, pipspage Feb 16, 2021
@licanhua licanhua marked this pull request as ready for review February 16, 2021 20:05
@licanhua
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@licanhua
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ranjeshj
ranjeshj approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@ranjeshj ranjeshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@licanhua licanhua merged commit 33ea9b5 into master Feb 17, 2021
@licanhua licanhua deleted the user/canli/fonts branch February 17, 2021 00:04
@mdtauk
Copy link
Contributor

mdtauk commented Feb 17, 2021

Why the move away from Chevrons to Caret? The FluentUI Icons include both.

image

image

@ghost
Copy link

ghost commented Mar 5, 2021

🎉Microsoft.UI.Xaml v2.6.0-prerelease.210227001 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksfoster marksfoster marksfoster left review comments

@ranjeshj ranjeshj ranjeshj approved these changes

Assignees
No one assigned
Labels
area-Styling area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@licanhua @mdtauk @ranjeshj @marksfoster @StephenLPeters