Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new CommandBarFlyout and Popup API's public. #5199

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

StephenLPeters
Copy link
Contributor

Move API's from Preview/Internal to Public

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 15, 2021
@StephenLPeters
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-Commanding AppBar, UICommand, MVVM, etc area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 15, 2021
{
Boolean AlwaysExpanded{ get; set; };
}
Boolean AlwaysExpanded{ get; set; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is adding to an existing type, we need to version it V2. See

// [MUX_PUBLIC_V2]

@StephenLPeters
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters merged commit 588a858 into main Jun 22, 2021
@StephenLPeters StephenLPeters deleted the user/stpete/PopupApisPublic branch June 22, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Commanding AppBar, UICommand, MVVM, etc area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants