-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Deprecated icons #8379
Fix Deprecated icons #8379
Conversation
FYI @crutkas, @StephenLPeters, @bpulliam, @niels9001, @1332186865, @randyrants and others |
Thanks. I will find someone from design team to review it. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hey @Jay-o-Way thanks so much for filing the bug and submitting the fix. I'm currently verifying with the designers to make sure these are apt replacements for the glyphs, as well as trying to identify how this regression happened in the first place... |
Thanks @karkarl . Same idea applies to the SymbolIcon application. Translating |
@karkarl Any progress? And, after this would be merged, when would the effects be visible? Any eta? First the next version of this source needs to be released, then apps (and don't forget the OS!) should update to use that new version. I imagine that takes quite some time... |
After some investigation, here is what is happening with the icons: Both Segoe MDL2 (Windows 10 icon font) and Segoe Fluent Icons (Windows 11 icon font) use the Unicode private use area (PUA) to encode icons. Some Chinese fonts encode Chinese characters in the PUA range. PUA range goes from Unicode E000-F8FF. Some simplified Chinese apps are reporting these issues. The only font that has Chinese characters in that lower PUA range is a font intended for Hong Kong (Mingliu_HKSCS). To avoid these codepoint collisions, it is recommended to use glyphs higher in range. Hence the note specified here: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-ui-symbol-font
Note that these glyph ranges are not really "deprecated" in the traditional sense (misleading doc). The icons are still encoded and left intact. Unfortunately, this also means that should fonts start encoding in the higher PUA ranges, more collisions like this can still occur. It still makes sense for us to update the glyphs, hence here are the next steps from our side:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
4c57749
into
microsoft:user/kmahone/fix-deprecated-icons
There is an issue in the validation Pipeline building from forks. So I've merged this into a local user branch and will merge it to main from there. |
See #8576 |
This is now merged to main. Thanks @Jay-o-Way for the fix. |
Thanks, that's great news! And special thanks to @karkarl for digging in to this. Looks like quite a lot of work went into it. And this is not even the end of the line. |
Description
Appended Icon Changes:
Motivation and Context
They have been deprecated for years now.
Fixes: #8375 and #7350
and many more, like