Fix horizontal scrolling on trackpad #8403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds check to mouse scrolling to see if horizontal scrolling is possible Fix microsoft#7772
microsoft-github-policy-service
bot
added
the
needs-triage
|
I don't know of a good way to add a test for this, given the issue you've noted. The change/risk is small enough that I'm satisfied with manual testing for horizontal wheel. Thanks for contributing this fix! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjamesmac
changed the title
|
Thanks @codendone for taking a look! |
codendone
approved these changes
May 2, 2023
|
Fix also merged into WinUI3 (internal bug). |
microsoft-github-policy-service
bot
removed
the
needs-triage
|
@codendone Thanks for merging this one. Is there an intended date for a release with this fix? |
kmahone
pushed a commit
that referenced
this pull request
Jul 7, 2023
Adds check to mouse scrolling to see if horizontal scrolling is possible Fix #7772 Co-authored-by: Thomas McAuliffe <tjamc@amazon.com>
kmahone
added a commit
that referenced
this pull request
Jul 7, 2023
Includes these fixes: * [Fix Deprecated icons ](#8576) * [Fix Voice Access 'Show Bubbles' annotation of WebView2 Content](#8551) * [Add const keyword to resolve warnings (treated as errors) C26462 and C26496](#8567) * [[WebView2] Apply text scale factor to CoreWebView2 content](#8540) * [Fix horizontal scrolling on trackpad](#8403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a boolean check to see if a horizontal scrolling is available
Description
Amended the
HandlePointerWheelChangedmethod to check if the mouse pointer is capable of being scrolled horizontally, if so, use a horizontal mouse wheel movement instead of a vertical oneMotivation and Context
Enables horizontal scrolling
Fixes #7772
How Has This Been Tested?
see above
Screenshots (if appropriate):
Before
before7.mp4
After
after7.mp4
EDIT:
After reading the contribution guidelines I thought creating an interaction test would be sufficient, similar to this test. However it seems that the test automation library doesn't have an equivalent method to enable horizontal scrolling. Is there a different way I could go about testing this fix? Appreciate any help as this is new to me.