Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continous benchmarking #277

Closed
lechu445 opened this issue Feb 16, 2023 · 1 comment · Fixed by #286
Closed

Continous benchmarking #277

lechu445 opened this issue Feb 16, 2023 · 1 comment · Fixed by #286

Comments

@lechu445
Copy link
Contributor

As this library is performance oriented, I think benchmark tests could be useful to spot any perf regressions. Also performance results can motivate contributors to improve the results.

As a first step, I'd suggest to use BenchmarkDotNet for the tests.

And in second step prepare Github action using github-action-benchmark to enable Continous Benchmarking.
@benmwatson
Copy link
Member

Agreed. This would be a great thing. If you want to get this started with some sample benchmarks, I'd love to see a PR.

@lechu445 lechu445 mentioned this issue Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add continuous benchmarking lechu445/Microsoft.IO.RecyclableMemoryStream
2 participants
@lechu445 @benmwatson