Is _MBCS required?

[degski]

The default solution file on Windows/VS20XX compiles the code as Multi Byte Character Set. This appears to have been done quite deliberately.

Is this really necessary or can the code also be compiled as UNICODE, which would be preferable.

[daanx]

Ah I see. I think I used _MBCS as I prefer to treat strings at UTF8 .(.. but that does not hold on Windows anyway as _MBCS does not use UTF8). So, mostly accidental -- nothing in mimalloc depends on this (as far as I know, perhaps the mi_realpath function needs an adjustment?)

[degski]

@daanx Thanks. So, it would be best to change the setup of the included vs-solution back to the default, UNICODE. Unless you call any Win32-API xxxxxA functions directly (as opposed to the xxxxxW) functions, nothing needs adjusting since they [the win-api functions] are all wrapped in macros (and selected based on _MBCS or _UNICODE being defined).

[daanx]

Fixed in #24feb5e

[degski]

Thanks, I've reverted to a simple build script, building a number of variants and then use auto-linking to pick the right one.