Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library versioning #9

Closed
ranisalt opened this issue Jun 22, 2019 · 3 comments
Closed

Library versioning #9

ranisalt opened this issue Jun 22, 2019 · 3 comments

Comments

@ranisalt
Copy link

ranisalt commented Jun 22, 2019 •
edited

The cmake install script should install the shared library to libmimalloc.so.<ABI version> and point a symlink to libmimalloc.so, instead it just installs to the latter. It should also add execution bit to it (chmod 755 instead of 644).
@ranisalt
Copy link
Author

Packaged it for Arch Linux: https://aur.archlinux.org/packages/mimalloc-git/

@daanx
Copy link
Collaborator

daanx commented Jun 23, 2019

That is great -- thanks for packaging it! I'll look into how to create symlinks and set execution bits using cmake...

@ErnyTech
Copy link

ErnyTech commented Jul 3, 2019

We need add SONAME to shared library for guarantee the compatibility of the abi

daanx added a commit that referenced this issue Sep 16, 2019
@daanx
set SONAME and use symbolic link at install (issue #9 and #58)
3a697ab
@daanx daanx closed this as completed Apr 6, 2020
@hp48gx hp48gx mentioned this issue Jun 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ranisalt @daanx @ErnyTech