remove MI_USE_LIBATOMIC and properly find libatomic #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanx
added a commit
that referenced
this pull request
May 19, 2024
daanx
added a commit
that referenced
this pull request
May 19, 2024
…lag first before using find_library (see also issue #898
|
Thanks so much! I refactored the cmake code to use the library flag check always first and fall back to find_library after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some systems, libatomic.so is at gcc specific dir(e.g.
/lib/gcc/powerpc-unknown-linux-gnu/13), rather than the system library path.In this case, find_library cannot find libatomic.
Use check_linker_flag to fix this, and remove unused MI_USE_LIBATOMIC option.
May fix #798
Tested in:
x86_64-pc-linux-musl
aarch64-unknown-linux-musl
armv6j-unknown-linux-musleabihf
powerpc-unknown-linux-gnu