Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tags to the IpConfiguration Datastructure #166

Merged
merged 17 commits into from
Aug 24, 2023

Conversation

gsicilianomsft
Copy link
Contributor

Add Tags value to the IpConfiguration data structure. This will be used to store the NC resource Id.
Also add a function to NetworkInterface to get the primary Ip Configuration from the list of IpConfigurations

Copy link

@in3xes in3xes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madhanrm I'm not sure about adding Tags to IpConfiguration here. Could you please take a look?

@gsicilianomsft
Copy link
Contributor Author

The added Tags are being used to store the resourceId/guid assigned to the ipConfiguration within the NetworkController. The guids need to be saved somewhere in Moc to allow update and syncing the ipConfigurations to NC. Guids present in NC that aren't in Moc are deleted for example.

Tags were used here in IpConfiguration because the Tag property was also used in NetworkInterface, and NC uses the same method to update the NetworkInterfaces by storing the NC NIC resourceId in the Tag of Moc's NetworkInterface object.

@gsicilianomsft
Copy link
Contributor Author

@madhanrm, if there are no other comments, this PR will be completed by the middle of this week

@nijosmsft
Copy link
Contributor

I am merging this PR. Following are the pipelines executed for this on top of wssdcloudagent.

Moc-cicd (modified with multi-ip tests): Pipelines - Run 20230821.9 (visualstudio.com)
Moc-cicd (Master branch): Pipelines - Run 20230818.5 (visualstudio.com)
e2e upgrade: Pipelines - Run 20230816.1 (visualstudio.com)
AksHci Upgrade CICD Daily: Pipelines - Run 20230823.5 (visualstudio.com)
akshci e2e cicd weekly (sdn skipped): Pipelines - Run 20230823.5 (visualstudio.com)
Failures are consistent with state of the pipeline
akshci e2e cicd weekly (sdn only): Pipelines - Run 20230822.2 (visualstudio.com)
Failures are consistent with state of the pipeline

@nijosmsft nijosmsft merged commit 908c6e5 into main Aug 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants