Support __webpack_public_path__

[rgbkrk]

We've made good use of this plugin in nteract/nteract#2779. We're running into one major issue though -- when we host our app on a subpath it appears that Monaco's webworkers aren't loading based on the __webpack_public_path__, instead relying only on the static publicPath in the webpack config.

What would we need to do to make monaco recognize the dynamic public path?

cc @yuvipanda

[dmitriylyner]

@rgbkrk This was recently fixed here: #14. Newest release of this plugin v1.3.0 should have this.

[rgbkrk]

🙏 Thank you!

[rgbkrk]

I'm currently running into an issue with this here: nteract/nteract#2992

$ npm ls monaco-editor-webpack-plugin
nteract-monorepo@0.0.0 /Users/kylek/code/src/github.com/nteract/nteract-ext
└── monaco-editor-webpack-plugin@1.3.0

[rgbkrk]

We dynamically set the __webpack_public_path__ well before monaco is loaded (it loads in a chunk, dynamically imported, much later).

[akihikodaki]

Confirmed the problem. It incorrectly refers to window.__webpack_public_path__.

[z1haze]

We dynamically set the __webpack_public_path__ well before monaco is loaded (it loads in a chunk, dynamically imported, much later).

Could you provide an example of how you're going about setting the __webpack_public_path__ before monaco-editor-webpack-plugin initializes? I don't see how that is feasible as at least in my situation the webpack public path variable is set at runtime.

I end up with files in the correct location but instead of webpack looking for files in the correct public path, it looks for them a domain.com/js/worker.js when in reality it is domain.com/multi-site-name/default/some-version-hash/js/worker.js. We need this plugin to respect the runtime setting of __webpack_public_path__

[ghost]

We wanted to provide an app which is loadable from any path, so therefore we dynamically determine the base path on runtime and use it as __webpack_public_path__. The determination happens in the index.html and afterwards based on the determined base path the bundle.js is loaded.

So therefore we also had the problem loading the editor.worker.js file.
We managed to overcome this problem by overriding the getWorkerUrl in the MonacoEnvironment object like this:

window.MonacoEnvironment = {
  getWorkerUrl(moduleId, label) {
    return `${BASE_PATH}${label == 'javascript' ? 'typescript' : 'editor'}.worker.js`;
  }
};

If you want to provide more languages then you have to consider more workers (see issue).
As long as this issue and the subsequent PR is open, this can be considered as a temporary solution.

I hope this helps some people.