Right click opening command palette window #1199

yln99517 · 2018-11-17T16:28:46Z

Steps or JS usage snippet reproducing the issue:
go here.
Playground

just right click on "module Conway {" on the editor. command palette opens up.

rebornix · 2018-11-17T18:53:21Z

@sbatten this is the same issue we ran into yesterday, let's fix this on Monday.

alexdima · 2018-11-19T08:51:00Z

I can reproduce. I think there are two issues hidden here.

The positioning is broken. No matter how much space there is below that location on the page, the context menu always wants to be rendered to the top:
There must be some form of double interpreting of the mouse event, where the first right click to show the context menu leads to the last entry being selected.

(I could grab the screenshot by using Shift+F10 to show the context menu instead of right clicking)

sbatten · 2018-11-19T17:55:41Z

@alexandrudima, 2 is expected, this behavior is to enable the right click hold, drag, select functionality. We've run into this issue multiple times on Linux because of placement (1 above) and @joaomoreno has fixed it a few times. I'll take a look today

joaomoreno · 2018-11-20T09:59:55Z

Placement seems to be wrong because the page actually scrolls.

alexdima · 2018-11-20T15:25:49Z

@sbatten @joaomoreno I would appreciate a fix for this when you get a chance, I'm waiting for this to make a new editor recovery release. Thanks!

sbatten · 2018-11-21T02:21:22Z

@joaomoreno looked into this and have ideas/concerns though I know you own this code and have made several changes to address this issue.

The anchor being used in the context view is 1px by 2px but it doesn't appear to be used as a radius, which means there isn't a guarantee of separation between the mouse and menu
I can get the menu to appear both below and above the mouse click though it seems to prefer above. Could you clarify what you meant about page scrolling?
Range intersect detection seems to count ends as exclusive and this might need to be taken into consideration?

joaomoreno · 2018-11-21T15:15:13Z

There were 3 issues:

The layout code wasn't respecting window.pageYOffset. That's what I meant @sbatten, when the page is scrolled down, we need to shift that math by that amount of pixels.
The menu was still being drawn right under the cursor, I shifted it by 2px to the side.
Focusing the menu was happening before it was laid out, so there was situations in which it would force the browser to scroll up just to reveal the focused element. Fixed that by having distinct render & focus steps.

@sandy081

b36ee32fe7 further fixes to microsoft/monaco-editor#1199 f325118205 Merge pull request #63572 from karanisverma/dev 3c97c46937 fix #63291 0d3a14402d fix issue with double menubar with unity ebf5f769f8 Allow editing multiple lines of text in the search view - fix #62304 af821e29f8 Log proxy resolution (#60773) 4abddd8678 Merge branch 'master' of https://github.com/Microsoft/vscode into dev fcf3883768 fix strict null checks 4d7ba5255c fix: fixed issue with strict null check 021d01b85c fix dropdown! a0df045e7d storage - handle case where DB is null when closing ce10e76d54 fix compile 7b7df809b6 storage - ensure to close DB on error 6dcade9ed5 update references view 2d4025bcc7 tree: expose onMouseClick and onMouseDblClick 11d5ed7959 storage - remember if workspace storage folder was created or not 03acf80627 rename isOnlyDevelopmentDependency to developmentDependency 92402b8e53 fixes microsoft/monaco-editor#1199 94f5a49633 simplify DataTree getChildren 86c490a1e2 make tree events simpler by not exposing nodes a649ade2b7 fix: returning undefined to ensure the default value is applied 866493efc8 Merge pull request #63565 from Microsoft/sandy081/fix63490 9809b07e00 update references-view-extension e023f4fa44 storage - bump telemetry ID again a5120a166f fix: #55946 Added comment snippet variable 8cb34d95fb storage - implement backup solution 2a695327f3 escape message 2e4837bb45 add comment to vscode.debug.activeDebugConsole; fixes #63489 b37c8a4008 Fix #63490 e6476417b8 Fix #63496 2e257cfc16 storage - easier tracing configuration e4ff48421e Remove TPromise from terminalTaskSystem.ts (#63562) 0e47177c78 perf - storage should only be in trace mode if enabled (!) 7ad56df3b3 Merge pull request #63514 from desaianuj/patch-2 3a2c8382f0 bump vscode-sqlite3@4.0.5 d817f4ed81 Merge pull request #63508 from Microsoft/alexr00/clearAPI f38b0ca033 fix build 45733ae2e4 bump vscode-sqlite3@4.0.4 2c9722a4c8 Clean up unused empty workspace storage folders (#63554) ac986e3962 Merge pull request #63341 from eamodio/fixes-markedstring-href-encoding aa4948a79d #23251 Install post install hook c348be666a Fix #63128 f837fd2f42 fix tracker problem on restart; fixes #63529 115ea4afe3 fix strict null error for debug c1722e940f emit debug activate events in parallel bb64221e5f Remove no longer needed license override 6cb5c23928 Update ThirdPartyNotices d6e3ecf982 fix spelling of "firstPage" 1e3efda93c polish cgmanifest.json 3fcb2d24d9 Use monospace font for hovers 085f4656ed add some commit hashes and versions to cgmanifest.json b134a61eb2 introduce 'onDebugAdapterProtocolTracker' activation event f8f7e7ea00 Fixes microsoft/monaco-editor#1196 8920420f5a Move clear API out of proposed 3a6362ef7f storage - bump telemetry id bf8c26d202 Remove no longer needed license overrides af951c6084 Tweak explanation e205d57441 Remove unnecessary licenses bf4734afbc bump vscode-sqlite3@4.0.3 ec98c79d44 Merge pull request #63497 from Microsoft/isidorn/cgmanifest 9edd984da8 delete OSSREADME.json 9a3758ea19 Revert "only run component governance" 621c45fbbe Fixes #63458: Restore stable mouse wheel logic 9e66eee67b Merge commit 'refs/pull/61454/head' of github.com:Microsoft/vscode into pr/61454 d50df7622b Merge branch 'pr/61454' 85dd134658 improve dropdown menu placement for sidebar parts acab80e2c8 Merge pull request #63329 from vbfox/patch-1 66f717cfa6 Merge pull request #60104 from mathiasvr/fix-60002 3af878c2d5 💄 6052fcf07f Merge commit 'refs/pull/59735/head' of github.com:Microsoft/vscode into pr/59735 6bb77146c4 Add a rerun last task command (#62645) 47b3238330 Fix #63295: Refer to Sudo in Linux Save Error Message (#63394) d37f7c1583 Always dispose of DecorationCSSRules 02a59c3015 Make CachedResponse generic fabc627634 Move getSymbolRange out of class 1f1618d280 Remove extra conditional f953906c74 Remove un-needed any cast 3b66ce3083 Mark fields readonly c4a8608f12 Don't cancel signature help until next real trigger 8047109d3d Always cancel parameter hints on retrigger 2fb2d49daf Use delayer for paramter hints trigger a2585f38fc Use hasModel 26cd646618 Remove unnessisary conditional 277b96327f Enable loading indicator for subsequent js/ts project loads b115d8860c Extract loadingIndicator to class 300f1b8d98 Extract lazy activation logic 509f1233e4 Debug API: add registerDebugAdapterTracker 18656c9c13 Extract to a method b678bfe16c Improve labels 575e1630d5 Add API so that extensions can configure TS Server plugins 848010a725 Strict null check configureSnippets 0e4d94e364 Stric tnull check snippetCompletionProvider 0cbb21ae6d Strict null check smartSelect 37f1605060 Strict null check snippetsFile.ts 66319f4a59 Strict null check environmentService 04067138d9 Strict null check snippetVariables 6448b30f36 Strict null check formatting edit 9867c9afad Strict null check chokidarWatcherService 9f5336555f Merge branch 'master' of https://github.com/Microsoft/vscode 87b9be19d6 remove toggle menu bar from mac menu fixes #63436 ebe9ea85a0 Temp fix for go to definition not working 0bfb7fcb54 Add metadata on completions accepted api 111c3f049a :chore: add todo 637604810f fix monaco-editor#1156 c11b5d39f0 fix #61899 ef81add153 debug: bring back clear console to command palette 347216b612 Merge pull request #63328 from sbatten/fix/62984 f6221e6522 Check for ui extension while installing vsix c2f1ea980b fix #63185 5e47cfc7c8 notifications - fix TS warning ad27c72153 fixes #63416 9906624a5f Rename e40df5770d adopt DAP attribute "runInTerminal.shellProcessId"; fixes #63434 ea771bdcd5 Fix #63433 a8dbfd2912 fix #62587 15177f207c Use file system service (#31450) 6b524707de 💄 6e30aa52cb debt - introduce and use in-memory storage for standalone editor c06861f4b2 Merge branch 'pr/62052' 0ffc6dbd74 strict null checks 352ede78ea list: finish dynamic height 49d011e481 💄 fc1816f741 diag - include OS in about dialog 82d00f5383 Merge commit 'refs/pull/62052/head' of github.com:Microsoft/vscode into pr/62052 f161d3fe3a Optimize parseStorage (#62805) 15ab767a1d #62795 Add proposed api to render description of a tree item 6e547ebf7c Fixes #62981: Adjust constants d01afdce7e update DAP e5406b523e introduce git.openDiffOnClick eb6025ec9b git.postCommitCommand b896eff28c Remove unused import fa367c25ff Fix: `foldersChecked` declared in wrong scope (#31450) b30a9835da fix strict null checks 420edabab8 rename tfs to azure-pipelines 03dd3dc4f3 remove winjs tpromise from async 9ee7aa35c2 fix smoke test 886201c9c5 use native promises in paging.ts 1c575a2df5 use native promises in Tree 31dc3f7894 Limit to application scope (#31450) dcc243c992 Better readability for util.ts 610918d48f Fix #62861 (Proper fix) e3db4665a0 Fixes stupid mistake 😞 6eb57f9952 add posinset to menu items fix #62007 66f4c5be3a Adopt OSS tool fc48088e76 re fix microsoft/monaco-editor#1013 b9d0981262 Fix TreeViewOptions comment markdown 5c353cc629 remove centered layout from layout menu 976cfe3aa7 Merge branch 'master' into isidorn/cgmanifest f526b7542f Check in composite bar for previous existence 0232d04cdc Revert "Rename placeholders to cached" ca1c923849 replace ossreadme with cargo.lock ff15cadc67 remove build/win32/OSSREADME.json bea83357a6 Fix can't click and drag to select text in the Debugger "Watch" pane 869e960b45 Rename placeholders to cached dadacfd4d5 Revert "Rename placeholders to cached" 724f3176fc Rename placeholders to cached f8a3d948c2 Should not have added the check 64db1642a0 cgmanifest: npm versions 6e8123a10b fix tests 9c655689da only run component governance 715c0d9b4e add cargo.lock 5a24c2e907 some tests for #62906 d93caa1d3d cleanup TPromise from sharedProcessMain.ts 1f7d35bd4b cleanup TPromise in sharedProcess.ts 09bd9f7dee fix smoketest: find all references c385dfe391 cleanup TPromise in driver.ts 7f8da219f6 cgmanifest npm dependencies ecaee2f53e Fix #63019 c507f6347b set outline label for TypeScript and launch.json, #62839 58d5205e5a naming and doc tweak for #62839 988f7683df Merge pull request #63150 from YisraelV/customNameForOutline 460166a294 fix #63216 0ac0c45b29 strict null work in extHostTypes, #61543 917a2c58ce Revert "strict null work in extHostTypes, #61543" 8f33d560b9 Prepare testing system proxy settings 714b18d16c strict null work in extHostTypes, #61543 a8838578af #61312 Implement message for tree views 759fec1680 rename 7f33701b5d add commit hashes for Joaos hipster dependencies f3e2c35a4a add repositoryUrl to build/win32 cgmanifest, somehow got skipped 61b9a88e52 Debug API: add DebugAdapterExecutableOptions; for #62977 040ee51d72 cgmanifest: some commit hashes 66b963d0cd set revealTop to 0, #63245 01d8ba6b8c add keepWhitespace-flag to completion item, #62057 d7f82c11d6 log telemetry event when we report unresponsiveness and crash, aftermath for #62970 and #62829 66461d30e0 use random port #60332 29fe3f317f make declaration provider api stable, #62483 6e44473c11 actually wire in go to declaration and peek declaration, #62483 850bbb275e Merge pull request #63069 from Microsoft/rmacfarlane/gitapi 453746bb25 💄 98bcd06d2f Merge commit 'refs/pull/63142/head' of github.com:Microsoft/vscode into pr/63142 f00cf99102 Can be undefined (#63033) 24b0f75b1e Refactor extensionTipsService for better readability 21405d5eb7 Comments for suggest widget cb1c3ed262 Remove unused method getAllRecommendations() f8a46bc570 Comments for different extension views a6b8074a19 Remove is 8244f81b65 Simplify data2String 78de541d49 Delete unused log level and type levels 07a5118d23 Make sure we dispose of pluginManager 0dd2f7487f Don't eagerly construct surveys a0f0ee42e9 Move survey ready logic into Surveyor 106cbdec2c Extract api to own file ca68cfd75d Split commands into own files dc03204cc2 Improve names 71f86e584d Merge plugin config provider into plugin manager 5da4d1188e Encapsulate plugins in plugins manager 01511eeb28 Make plugin.languages readonly 49fd31af84 Move plugin config provider to plugins file 3c78e312c6 Remove extra tslint file f9acec50c9 Pick up new tslint version ac95482f6d Pick up TS 3.2 rc 65a041476a Update tslint plugin version 6265ee5fca ensure backward compatibility for Tracker 0aafeac4a8 Update md grammar e4d0269c6a Strict null check decorationsService 556f042248 Strict null check work 4511fa3776 Debug API: comment cosmetic bafc2298ec Debug API: finalize new DebugSession attributes; fixes #51785 0f288f7af6 Debug API: finalize breakpoint ID; fixes #48722 f8b22a66d5 add peek declaration commands, #62483 11c473d3b8 Have overwriteEncoding be called 02c20ee23b Redirect vscode-resource requests 2ff2c61cde remove TPromise from win32 updateService f4c2b2021d debt: remove TPromise from cli 2ba92aa3e8 add commitHash to cgmanifest 4ccfe19815 Include extension version 028764fad7 #62870 Show all system extensions in dev mode 1a12e0a02a Fix #62870 7baccc2f97 remove default fields from launch.json 5afd6bb79e Fixes microsoft/monaco-editor#1191 4fd60ed5b5 Fix #62861 8383d42427 fix suggest widget in standalone editor fdfe5099a7 cleanup a57464eae5 linux build 656a6dc881 linux build 86f3230ecc move off Linux Hosted 76689e06f5 reset state machine when removing a scheme, #62800 4ac76090d4 use state machine for link detection, #62800 6e9070f5c4 Handle on non-Windows (#63208) f5dca934f2 Fix #62489 aab56e95c6 Fix #62370 f8ea816ca5 tweak regex #62800 22589dc890 debug hover has a fixed height: include height of horizontal scroll bar into computation c515ed99c6 tree horizontoal scrolling: pretend the content has extra 10px instead of pretending the view is 10px shorter e7f0b64a1a Fixes microsoft/monaco-editor#1013 2836b09e4b Use <user-file-path> instead of aaaaaaaaaa (#63075) df8ea54c53 Bump node2 663f427015 Attempt to fix #63047 f31bc50d1c Use correct position for requesting closing jsx tags 5867b96a25 More Promise removal 30b2a5fd94 Replace !isFalsyOrEmpty with isNonEmptyArray 8392c36a49 Introduce isNonEmptyArray f205b5a846 Fix refactoring action provider not being queried when using a kind filter 80aeb774f6 Fix possible undefined access exception when using apply "first" for a code action and no code actions are returned 3c6b6e614d Fix #63033 a832bf0879 Fix #63088 92f9f50a93 Don't disable manual code action requests on blank lines c7af5bdf26 Use hasModel type guard 813d3aa393 Fixing some more restrictive tslint errors bd314b04a8 Remove extra await 3aa49aa583 Improve method names d6b6c51b6e Make sure we dispose of reader properly 6ef7e81ec0 Fix #62980 347fb6347b add all cgmanifests. Still no commitHash c8cbfdad24 Revert "Fix #62980" e97f612172 Fix #62980 1cf9a6eb53 Make capabilities dynamic 5a8087c60e custom name when there are multiple outline providers cd547158be tree: if horizontal scrolling is enabled leave space for it 55f63af5a7 Fix #60014 56307cf9f5 fix #63126 63fdd96218 fixes #61986 aa4ef3a42c only add focus change listener once e2f8c3c404 Debug API: surface Breakpoint.id; for microsoft/vscode#48722 99f8f2492b Fix #62794 78dc613940 Do not pass context explicitly c9408a6940 add LocationLink use it in Declaration-type, make DefinitionLink an alias, #62483 8a50fcabc5 tweaks 74bb246cc0 Move uri transformer to shared process 08aa66112f node-debug@1.30.1 a08a3c6473 Fixes microsoft/monaco-editor#1183 3f6901d478 correct fix for #63028 33c89529be fix #63062 b7816b0629 Merge pull request #63096 from eamodio/fixes-markedstring-href-encoding 237b77bac9 prepare for ts 3.2 e9932be154 Fixes #63095 - html encode hrefs in marked strings 5fc60ec679 Fix #63015 c95cd6cae1 Strict null auto add 4737e3efd1 Fixing TS 3.2 compile errors 4f227dd88c Use 'references' instead of 'occurrence' to power document highlights ad5f5ea365 Expose 'apply' and 'diff --cached' from git extension API 61e117b234 fix #63028 fb61dd1885 add config to vscode.DebugSession 63b07c144d make IConfig.name mandatory b9fc2c1c20 debug api: add workspacefolder to DebugSession 06a6d53984 Fixes #62981 3ad0008f78 Merge pull request #63027 from Logerfo/master b1f471ffc5 Merge branch 'master' into pr/Logerfo/63027 be204fd116 Tweaks to channel usages d4bfba4653 Execute extension webpacking in sequence 989b7ae360 send duration as micro seconds, #60332 907fc79fe8 debt - less TPromise b896c6bdae grow background images with height (#62483) and a better fix for icon twitch 6e465986a7 Fix editor publishing scripts (on Windows) 746b5ea582 CompletionItem.insertText is not optional 9cbccdc2c5 Fixes microsoft/monaco-editor#1176 8f21d86c00 Fix some types cc3a1359ba Fixes microsoft/monaco-editor#1003 39199e8daa Restore that the editor can run in a browser b4c6906b62 explorer do not always reaveal in middle, jump less 624c59c62e remove commit hash as tryout 3fc698a8f8 fix strict null checks in remoteAgentServiceImpl f2c03b4a46 fix strict null checks in downloadIpc 6bd6732a54 add alias type for Declaration, #62483 2a891803f1 stop profiling as soon as extension host is responsive again, #60332 22d167bef8 Strict null checks for keyboardMapperTestUtils c5718c615d remove logic to show an exthost-unresponsive message to the user, #60332 6f594d0885 exploration 138e66a722 fail silent when not able to connect, #60332 cf80d92302 update ref-view extension c4d753a603 #62370 Render source and code less prominent 77b13e3478 test cgamnifests 95190ed713 💄 8c2d3b40e1 add connection context to IPC e1d6796e98 fix warning 6aa1325621 remove workbench layout perf marks 21f8789726 Autodetect ksh scripts as shellscript (#62838) 1df80b25cc fix command name for toggle centered layout 052cfa0dd2 event - forward custom leakage threshold to monitor b548ced43c event - add leakage warning threshold logic and configure for renderer fc3083ddf8 tasks.json should use deprecation message for env. config. and command. (#62787) c72cb129f2 Bump node2 54fb49cdc5 Don't take user file associations into account for webview mime types 8ec8c9774c debug API: introduce DebugAdapterProvider fd824ee58e Don't explicitly add folder name to task labels 573af50461 Switch VS Code workspace to use typescript-tslint-plugin 66c71d797e Fix overload 18cf781845 Strict null check extensionsAutoProfiler 0fe9a42afd Strict null check state service 9cf442e472 Strict null check zip 3c2ed748d4 Strict null check menusExtensionPoint aa33c3d22c Strict null check downloadIpc fa8b3cce7e Strict null auto add 0a1eb06fd5 Merge pull request #59193 from usernamehw/copy_empty 642cbc9f02 Ensure menus with no group specified have proper grouping 30fb7804c9 Auto close <> in js/ts fedb338222 Merge pull request #61993 from iBlackShadow/iblackshadow/fix-search-history-not-being-saved 57336b335a Format searchView.ts 6040b146d0 tweak telemetry #60332 2e43216c4a fix compile issue ee4d104004 always enable extension host profiling 118c31ed9e first cut of auto extension profiler, #60332 b35d879f76 update v8 profiler package 3a08ae630c Merge pull request #61926 from philiparola/master 13b45dba87 repl: Ignore inactive sessions which got cleared - so they are not shown any more 95ca89baf7 ipc: improve serialization perf, add array support f9a9e4e748 enable custom title/menus on linux (#62866) 9c6b628e91 null checks 201d3e75e1 update monaco.d.ts bbc5b9e619 tweaks 5ed816b5e7 Fix tests aeae5a5120 Explore c0fb67a9e3 💄 84cd19b9b3 explore extensions management effad7f95b debt - less TPromise 0da851cde4 fixes #62606 26d154b78d assign max-height to type-label to prevent icon height changes, #62758 d4b84e645f fix #62344 f6bf792dea add API command for declaration provider, #62483 8bead9241f add missing monaco.d.ts 201b6dac6a add proposed api for declaration provider, add test, add ipc logic, #62483 bfd40c5a99 add internal interfaces and actions for go to declaration, #62483 8e55669bb7 fix #62059 6357004fe8 Merge branch 'win32-sign' 723ea47d62 fixes #62865 e92b1ac386 add some padding right to code lens, #62842 76ee724e18 split view views: do not jump when revealing 60e644cac4 remove sha1 win32 cert signing 0e265999ad fixes #62873 1ae88a3e7d Setting tab details opacity after #61371 d8cd7b8692 Fix missing high-contrast outline in settings editor 910ddad3e4 Fix #59444 5f58ff2ad9 Merge pull request #61371 from c5inco/tabs-fix 1dfdd75e1b Merge branch 'master' into iblackshadow/fix-search-history-not-being-saved 3863030994 Add an entry to the search history every time a search is done 0183d84fa2 Fixes microsoft/monaco-editor#1120 6cce81cede Fixes #62835 092132a074 Merge pull request #62293 from gpoussel/fix-62278 61feb91ec7 Do not terminate link if `[` occurs in the authority section of URLs (allow for ipv6 authorities) 1127800a2f Merge pull request #62667 from YisraelV/deleteCommand f6aef925f5 Test & tweaks 98b8fdfb96 Use overload for #62806 a3fa56b477 Observe isIncomplete metadata passed by from a plugin 2683f65e73 Strict null check driver e3965e5a35 Strict null check inPlaceReplace 0ff572f07b Strict null checking editor/contrib/format bdc9479573 Strict null check storageService ba97287ced Strict null check launch service 026df2745e lines operations strict null check. 914c6d969a More native promise adoption cc785ad473 More native promise adoption 87f7ce05df Native promise adoption 0dcc8e4dc4 inPlaceReplace strict null checks. b4aafa6ae2 Indentation strict null checks 32eb81c39b go to error strict null checks. b40a60e8d5 Parameter hint strict null checks. 1f3632bd8f Color Picker null checks. 2c82909b21 dispose submenu after use (#62848) c1d07a6037 Fix potential submenu leak #62829 aa98c2225f Fix #60453 12bbfe9607 explore classifying extensions 1ce79806c0 fix #62849 6441e79f29 Some tweaks faa78d3b80 Reset extension enablement on install 90abb702fa #53526 Migrate from TPromise 1609b01684 Migrate from TPromise c9cf18e109 Wait some more e839e4560c dispose command-palette after usage, #62829 a4d87f73f1 debug: do not report cancled error message 9e447b038c Depended on background tasks should only be run once (#62784) d5e0da8fd8 debug: minor polish (remove public keyword for consistency) cc80ec8144 debug: minor polish be0c72b98d add missing return 4f38bbdcd2 #53526 Migrate from TPromise 07e81e6e4d #53526 Migrate from TPromise in Keybindings Editor 67329220a6 #53526 MIgrate from TPromise in log 33b19e1337 #53526 Migrate from TPromise in localizations 604b9b9bf5 #53526 Migrate from TPromise in Output panel f6ab4302c5 #53526 Migrate away from TPromise in Problems panel 0e966cd3fd #53526 Migrate away from TPromise in Localizations land fe5fbc2d2b #53526 Migrate away from TPromise in views land 11194a18b7 more missing monaco.d.ts a0a34534d2 make debug State a const enum abbaa68483 Telemetry for extension activation times d5cc4a0678 debug: make sure to dispose contributed context menu 088b323ff4 missing monaco.d.ts changes d4116a8f38 tweak markdown string conversion and rendering 0b99867455 working on markdown string dto c15559789f add Uri.parse(value, strict) so that missing scheme throw 1c60855e32 Update extHostDebugService.ts f637774b08 Merge pull request #62823 from leonm1/master f9307094ba Try fix timing issues 5ce5356124 Revert "Make vscode.executeCommand('vscode.previewHtml', ...) a compile error" b566562afd Fix #62785 empty lines in debug console copyAll f5433ed8eb Revert strict null checks on config 5acd78e288 Strict null checks cb05d8fdf3 Strict null checks cf4e17cd4b Remove windows-process-tree types if they get installed e74aa5aa2e Fix windows process tree being included twice on windows d5c11916a1 Support rendering color completions from a ts plugin as colors in the suggest list 4ef037df69 Strict null checks d98b92f414 Update distro. 7ff0971c85 Fix comment update event 0a2d071eb7 Strict null checking config f742c33ab6 Strict null check quick open scorer 20153f1d67 Fix strict null check 783ed71ad7 Tweaks e99b83dd90 Fix #62340 - don't try to update text model after it's been disposed af1b4ebded Refactoring comment service to not be keyed on handle 88bb48278d Authority exploration 73453050fc Fix #62031 599ae17966 Fix NPE from #46353 96ddd4f288 Make vscode.executeCommand('vscode.previewHtml', ...) a compile error ae8c6d07fb Attempt to fix flaky search tests 894cda8dec Fix strict null checks 4b7fdd8c5b Fix #46353 - add warning that "Use excludes and ignore files" is turned off c7a24d091f Fix #36309 - remap \W, \s, and \n in regex to match editor regex search 0f4fab159f fix linux build 4533aa0c0a Merge pull request #62739 from RDIL/master 3040fd59ee explorer: fix memento state regression bae7a2b167 cleanup build folder 605139f4a9 cleanup snap build c850728ddd build e4f9cae949 Merge remote-tracking branch 'origin/master' into snap 5c3e3ec85a snap updates 1c3d278021 toward strict null in extHostTypes #61543 b5375010dc fixes #62778 9aebfa2c86 Use ES6 promises e1f56eecf0 snap update service be4e8491f7 fix #62772 9c511dcd12 Reconfigure default build and test tasks should update tasks.json (#61857) ffdd2d91b0 #61590 add edit json action for keybindings editor f5b5630d90 Copy settings scope and query when switching from UI to json - Fix #61590 0ea57dc64f #61590 - show settings editor actions in editor toolbar instead of private ... menu c8a6e6e838 Tweaks 7f9d701259 Clean up old rg cli props f0f3b922bc Only set --encoding flag when files.encoding is set. For some reason, --encoding=utf8 is slower when searching large binary files with \n in the query... 83660da7ea Replace TPromise in settings #53526 ca6e101a11 Update distro hash 9e8719ba79 Add alert when trying to use the previewHtml command while developing an extension 0566eac64b Auto add strict null checks 9c1fb078f2 Allow-list cleidigh and usernamehw (#56883) faa6d4ab2b Enhance LabelService b692cd9034 Merge pull request #1 from RDIL/imgbot e146b7aad6 Tweak IExtHostContext 97a1ccf187 Render more details in running extensions 7feea007bf Exploration with authority dc63f09348 Minor tweaks 6ba5f8f9f3 Final search TPromise removal #53526 249b59ed9e Fix more error handlers behind Promise.join 9bea4fae10 Remove TPromise from search land #53526 9669edc50c #53526 - remove TPromise from SearchService 03cf7b9e7e #53526 - remove some TPromise references from search proc b60903d3c2 Remove no longer necessary 'use strict' 40a6a2db9a Expose force flag for deleting branch on git extension API 7349680db4 Better timeout installation dc6a3d1f98 Tweaks to transformer eb87600bd3 Use more URIs 0129edae63 Expand comment reply area on focus ffba25fc25 Add compilation output c2a09ed400 Minor tweaks f11391f6eb fix artifacts 9708588c1d debt - less TPromise #53526 b9c5f2f65e 💄 3e6a5fe47e tweak snippet 86fa4e4957 use snap cleanbuild 024be14622 build d90d8d9b3c debt - less TPromise #53526 3aacda87e0 💄 9e5b12a73c debt - use const enum for MenuId 14d41f25eb bring back snap build tasks f7f121bf19 remove build message 18a843abb4 fix #62526 391819f002 set exec bit b8e7442f5d set exec bit 67a8eb6e6e fix #62208 df6ca821a6 remove args from electron launch 4ae69c8c4a cleanup snapcraft.yaml 1cffd55dc9 reenable builds 8455a0aa95 Convert TPromose -> Promise 364e1a8505 Convert TPromise -> Promise. 362e69ad83 simplify code, #62335 ba9f4099c7 fix #62335 a6fe9800e9 mainThreadDebugService: get rid of TPromise cb8a56c872 fix build 3fa1388abe contextMenuDelegate: getActions is no longer async 872cbd7dfc 'custom' task type should be '$customized' to conform to API doc (#62710) cfd2ea16e8 Update NPM script explorer tree view when package.json changes f6662acf9c build 32bit snap aa3b1fb31b viewsViewlet: openView is not async 8f3f462cb3 debt - less TPromise instantiation #53526 79591ff89d debt - remove TPromise from action provider interface because it is never async, #53526 36ad2cc2ba debug: To reduce flashing of the path name and the way we fetch stack frame. We need to compute the source name based on the other frames in the stale call stack c475d3d906 debug: only append stale call stack if there are more frames to come 8f2cb25f96 debt - less TPromise #53526 ac88b2fe70 isolated yarn build 54e59d2608 yarn 1ed635852b debt - more TPromise removal #53526 ddd7926f60 debt - less TPromise #53526 4bbc0dc55d build 32acaac60b snap command 39818e34fb snap b26a50f1e9 add notification for linux issue (#62683) 38274edfcb snap 40330e4427 snap 284864239f Strict null check paths.ts d412f89baf [ImgBot] Optimize images 64c551a9ef Sort tsconfig.strictNullChecks.json d2915a1652 Strict null check more search files c91cdeddaa Fix return of openReporter in issueService af6ec9176b strict null check replace.ts 42c716dc25 Strict null check more search files 1d44116fd6 Add textSearchManager to strict null checks defa76edcc strict-null-check ripgrepSearchUtils 56b7fcb146 Fix menuService path in strictNullChecks list c495e403f0 get node in build aa343e44c0 Remove TPromise from issue service, #53526 af65e5f3aa get snap building 01337050b1 debt - Barrier use real promise ed4e8e4eb2 debt - let menu listen to (new) menu registry change events instead of listing to the extension host being ready. that simplifies this a lot and help with show menu sooner e556d244ff debt - less TPromise cc2fe60d1f comment out component detection a15c47256a faster build 5248363beb build 6c11772d0c build 4dd06b1696 whitespace dc0bbfe806 tfs snaps a519549d38 mock debug: return type 9c4b3954c2 update snapcraft.yaml e4040bef60 fix #62112 - merge overlapping delete operations 132ddb4ee5 cleanup debugConfigurationProviders properly 87f69fec4e let's go crazy: use native promise in debug land e840e83ff9 set executable bits 0d5ddeb9f4 debug: make sure debug stop can stop initializing state 5b3eff0036 add LinuxSnap build step 636ad4fa95 cleanup linux yaml build definition ada11bfc33 strict null trouble 3acc0026ab debt - less TPromise construction 72fd692827 whitespace e99942ccc3 Update makefile colorize tests according to the latest grammar. (#61961) 755c02a3ab Fixes #62655: mainThreadTask should use unique keys for task provider registration 9074cf8181 add test for #61919 1ec6d3c21f strictNull trouble c48845126e clone DAP messages properly edf7e05230 Handle error (#31450) e6a3b8f98c Show README instead of welcome page, if it exists (#60061) 488fa952c0 add log messages for all language features (IntelliSense, formatting etc) fixes #43099 97012b288d fixes #62390 f8299f070b Merge branch 'master' into tyriar/snap c71f524777 Updated grammars 6eb24fb349 Themable Welcome background (fixes #46816) d119e01a8f Reload grunt and jake tasks after npm install c686a15384 After npm install gulp extension should find tasks (#62129) 975351e639 debt - remove TPromise from telemetry world 3a0d406488 Fix #59926 20130d4938 Fixes #62649: Don't serialize URI as JSON in DTOs 10968e3ee6 revert debt - remove now obsolete smoothScrollingWorkaround setting 650a18e3f4 debt - less TPromise in service interface 340133accd Revert "Add strict null checks in issue and launch services, #60565" 6f139c79ad Test for multiline selection for wrap d8cce48edd Update markdown grammar cd1a6b4fbe Add strict null checks in issue and launch services, #60565 8784755458 Use TS 3.1.4 for building VS Code 812a35fc39 Update js/ts grammar 6e5b0be369 Use set instead instead of regexp for kind modifiers 92fc1f1f74 Enable file icons for js/ts path intellisense d5913e54b7 Always show the code action light bulb if quick fixes or refactorings are available edce7e2b8d Version js/ts Api f5e8321964 Remove comment user icons that fail to load b929dc93d3 Use api for onCompletionAccepted instead of command b4b3f75deb Fix #62446, increase opacity of selection highlight bg 170077d533 Adding command that is fired when a js/ts completion is accepted fec1775aa5 Strict null checks 10b95a0b88 Fix strict-null-check fd87535685 Fix #62409 - resolve exclude patterns for searchPaths correctly 07340673ea Strict null checks 580619e8b6 Fix strict null errors in encoding and storage 234ccfa412 Strict null checks 2f85cd4541 Send only needed extension data to issue reporter, fixes #62481 3e5e6e6baf Clean up unused parameter from PR 2f81ec4eb8 remove unnecessary filter conversion (#62505) ed84ffaf05 debug issues to weinand 654692234b debug: add "Run to Cursor" to command palette b7761829fb debt - less TPromise 5c6694ca28 fix #62457 b862791cf2 Fix merge compile error 41c02aa888 Fixes #62594: Resolving process task doesn't take task system into account fb9e1da186 update git iconv-lite dependency 54a0868259 enable component detection in product builds 1a88afd1b6 debug repl: Make sure to select the session if debugging is already active 90d02d3bdf Merge pull request #62504 from cleidigh/selectbox-vo-label a0b871880e strict null checks: add dataTree 4ad30a4b56 strict null checks: add objectTreeModel 28db446e83 strict null checks: add indexTreeModel 5039d4a089 strict null checks: abstractTree d51f8c7fe1 move ITreeModelOptions to /tree 43de37cab4 strict null checks: several ipc utils f695de3a3f strict null checks: issueIpc.ts a76cfdb609 strict null checks: grid.ts c59c2374b0 disable bogous test, #62587 7dd291b51c debt - less TPromise in mainThread-things 0817eb5df5 debt - less TPromise in tests 9298df91e3 debt - less TPromise in webview stuff 03a1417d75 Merge branch 'dbaeumer/56721' 90fe5c8ba8 Clear doesn't work for extension contributed tasks (#62495) 108e4d54ca sidebarFocus -> sideBarFocus. Part of #62270 a0d81c9ffc null checks 29a6e3d3ca Merge remote-tracking branch 'origin/master' into tyriar/snap ae5b8fb197 Added ability to output extension info to clipboard (#56514) 297380be44 Force InstallCount sort only for empty extension query #62426 a7e362ccc9 SelectBox: ComboBox role workaround for native select Addresses: #60929 649f448ef9 Fix #62146, Fix #62149 ad95ccefbb Extension install error copyediting 41464748ab Fix typo, mismatch whitespaces in comments. c5c0d68c16 Fix typo in comments 4ed633d049 Fix typo in comments 1820a98e91 Fix css dependency ee4a0717f9 Update css service for #62159 8e841f4454 fix #62460 ef872dbbb7 Merge pull request #62294 from xfix/patch-3 1f9ec6560f Merge pull request #51197 from JeffreyCA/smooth-caret-animation fe06d8acf4 Merge remote-tracking branch 'origin/master' into pr/JeffreyCA/51197 dc1777cd9c Merge pull request #50534 from AdrieanKhisbe/grammar-injection-consider-general-types 189841a8b4 update references-view extension 7a8f665d93 Merge remote-tracking branch 'origin/master' into pr/AdrieanKhisbe/50534 6eb9ac0f09 Merge pull request #50312 from irrationalRock/fix-34345 0cc4ced7d6 Remove default keybindings a63d87d34e Merge remote-tracking branch 'origin/master' into pr/irrationalRock/50312 c49207f9a3 fix localization smoketest f9f38b2bbf update distro 72df509444 version bump f25673e310 update distro cf238ba584 allow references view to use proposed api, add as built in extension 718a093237 commands and widgets do not get along nicely 3e7f8dffc1 node-debug@1.29.2 0b35bdac93 remove bad submodule 1cc0913edc fix #62220 327613fbcd repl: only dispose listener if a new session is selected b5a3c690c6 fix #62412 164eab9b51 💄 ae2e4dec48 fixes #61524 220bff273e debug: workaround out of precaustion end intiialising state when adapter ends 784750fb94 Remove trailing comma 1b20f1aefb Update GDPR annotation 05c1edc2d7 Re microsoft/vscode-pull-request-github#652. Reply/Add comment button should be enabled if the comment editor is not empty. ff14a20f03 Fix microsoft/vscode-pull-request-github#652. Cache in progress new comment. 972096c90c Skip malicious check when --disable-extensions (#62351) 723ef6123e fixes #61154 886d14cee2 fix uri matches af5f77bb5f tree: pass along parent visibility to filter function 986b5532b5 fixes #60664 b7eb0f4040 Update css/less/scss config to make validProperty an string[] f835838de3 Fixes #60037, remove padding rule in find widget when collapsed 2b1d06feb9 fixes #18673 50a4525420 fixes #60986 7595bef509 fixes #61534 f689e899ec Update distro 03f7c83b23 Fix #62341 32e0f82795 fixes #62168 6e92e3aca1 Revert "cache panel body size" 349e31fee9 fixes #58918 b31b07741b Change settings for splitCwd to workspaceRoot, initial, and inherited. 269ae7b3a6 Pick up change to fall back to DIRECT f1736d3c89 do not show add configuration button for readOnly editors 66a49b23da cleaner git push api 0aa28f556e Merge commit 'refs/pull/61448/head' of github.com:Microsoft/vscode into pr/61448 aee5ffa4e3 Merge pull request #62283 from xfix/patch-1 649b8759eb 💄 1faae7e83f Make sure we activate js/ts extension when someone sends the _typescript.configurePlugin command d7ac6e838f Avoid creating AppInsightsAppender when --disable-telemetry (#62353) 25069f480f Fix #62338 - missing 'limitHit' from text search 7254929a0c Bump node2 - #61711, #62354 e20534c0b2 Fix extension sort order when running experiments (#62247) 64432976af fix keyboard shortcuts from conflicting with mnemonics fixes #61038 fixes #61644 8c2d81ea54 fix some menubar fallback items fixes #62133 261e2776eb Update css service to fix Selector Specificity issues 6800cb4a12 Remove self from auto assign cec19a1cea Add description proposed dts file for #33358 f748c0b163 fixes #61273 7cbabd3828 debug: if no thread is focused take the first thread 14331632b2 Update css service for #62163 988c2fa767 Update validProperties description. Fix #62162 6c6dfcc35c Fix #62186 - issues with some multiline matches b05c3c72ac Revert "Use new rg --crlf instead of diy solution" d02227a868 Merge pull request #62260 from Microsoft/alexr00/improveWorkspaceRootDescription 36790dd767 Fixing a few errors in plugin TS config command 92aac989b1 Fix typo in code comment 21b3651b24 Add a semicolon at end of non-built-in languages list e97e934b8b Fix whitespace errors in markdown files adade079ed Use default title for delete comment dialog, fixes microsoft/vscode-pull-request-github#648 fe5db1a8f5 sidebar -> Side Bar. Fix #62218 3d43f25e86 fixes #62090 6a25d333db fixes #62158 130f7a7ee1 Update src/vs/workbench/services/files/electron-browser/fileService.ts (#62296) 15ed89c0ee fixes #61259 d2f23b83a4 fixes #61269 0ea372371e Fix accidental fallthrough in snapshot loader 00135a26c1 Merge pull request #62268 from gpoussel/fix-62207 15ac8564c1 fixes #62202 f97a4b48a1 Fix #60097 270f7ddc0f fixes #62091 d9c4b5046b Fix #62223 9f4969b523 do not show undefined label bddb39d5d7 Fix #62278: IPv6 links support 945b43f31c Fix #61507 78150459c5 Fixes #56721: Problem matcher `fileLocation` isn't copied when using `base` bc69213320 Fix typos ba61718a03 Fixes #62030: Ensure user configuration is always applied 866fc31f87 Remove useless assignment of a promise 0b8d4ccedb Clarify types (help TS compiler) df8bba1247 fixes #62266 0077cb2d8c Fix #62207 ('null' tooltips on Quick Open view) e87a046ca2 Fixes #62175 121653f027 Fix terminal split for single root workspace (#62259) 78f452f838 Description for splitCwd workspaceRoot in multi-root workspace 2fade80c7f #62205 Change to number and Improve doc 028f3c19ad Fix #62210 e71ba77ec8 storage - disable automated integrity check for now 5f973bc6e8 fix #62152 97ad72a02c Dont enable commit characters in case where cursor is at dot preceeded by whitespace 0cb6c9f8b1 💄 99736e4153 Fix group by server 80a9b809eb typo fix 4f381fcb60 update distro e21df781db Treat data: as a known markdown link scheme 60bd4f9a9c vscode-xterm@3.9.0-beta13 169993fb30 storage - remove logStorage option (for #62152) 1d760ea4b4 fix #62145 2ddd5979f1 fix #62161 9eceaa4c8b storage - less waterfall startup 4b2fac2b6d Bump node2, fix #62164 c0fd233eff Fix GDPR comment 455552dee0 'Run to Cursor' option not offered on sources that were loaded readonly 2b06dd1ca3 Revert #61831 (fixes #62131) d80915b0a2 fix #62095 48282551ec Fix GDPR comments d150c48f7b storage - use all() over each() 35a3be5b5f storage - move error listener up 08d8211308 storage - flush with delay of 0 on shutdown d8c42ed004 bump node2 def0c260d4 Pick up latest js/ts grammar b72c349e05 Don't try re-encoding vscode-resoure markdown links a14b154f88 Minor style updates (#60304) d38bef2314 Pick up TS 3.1.4 9eef0151f6 Fix searcherror integration tests 1fbb0d484e Run .integrationtest.js tests first 36dc10c9f7 Add log for registering workspace comment provider 70b2d7b0ca fixes #62086 aa98bcaad4 Add scheme in URIDescripitor. 047f07958d Add notification to searchview for search.usePCRE2 549b669d4f Typing for search errors 0727358bfd When search fails due to a non-standard encoding, show a notification to help people find the new setting 317fe8088c Log an event on webview panel creation 45826e941f do not suppress first loadedScripts event; fixes #59281 f308bea367 Merge pull request #61419 from c5inco/font-updates db02d57569 Introduce plugin config provider 2f18a14a5f Support configuring TypeScript plugins (#61756) 26c3d8d890 Merge pull request #60219 from xxyy/pn/51032/json-status-bar fa9d7fc761 only show alert 41ddd41b71 Fix #59286 4beb0d5465 debt - limiter(1) => queue 196b1b282a Merge pull request #60080 from mrkno/fix/59323-long-delay-filtering-problems 0fd2ffaaa9 comments 331316207c fixes #60767 940acc1e17 Merge pull request #61584 from Microsoft/alexr00/fixWorkspaceRootSplit 22951130d3 mention issue 42d4374c8b woraround #62072 f8fd35b8cd Add proxy stats (#60773) 6d923688da git: create branch without checkout 3cd470ed7d improve titlebarpart layout perf (#60566) c11c416340 rename proposed IDebugAdapterTracker to DebugAdapterTracker; fixes #59420 2635578983 timeout for provideDebugAdapterTracker; fixes #59408 ec8eb95d70 storage - handle SQLITE_CORRUPT error c9fc3dbd7b fix #59410 1d55212ec0 storage - back to PRAGMA check on startup 08d383346c git extension api docs 65143c991f [html] update service 971e4ce8b2 [json] update service 5043998c52 css: valid properties 61c0fe6f00 storage - add comment c3572ebf6f storage - handle SQLITE_BUSY error with retry e2d9b3692c storage - tweak telemetry 318250ae12 Fix #61970 8db3ee0038 fix tests f43082614e Check proposed api for label highlights 9754563ea8 debug: add session to model immediatly 591c2893da Fix #60481 25589f6cc4 let tree highlights use editor find background, fyi @sandy081 25e4ab94b7 osstool 1.29 4d9bd458b4 fix tests 3f7e8b4d3d Fixed: quickOpenController / trim whitespaces (#62019) a3549d44d2 #55879 Set cap to max 3 levels to expand b434afd90d storage - add workbench.enableLegacyStorage setting as emergency in case new solution fails for someone 8adb061adc #55879 Add expand option to reveal API c391faf35a _vscodeSystemProxy option (#60773) 1a1c4979d7 fix npe 90185b889a hide activation message after 5 seconds, #61846 4bd295b6e4 fix strict null 18177c58cc Add a tooltip to scripts in NPM script view (#61596) d393578d58 storage - switch to throttled delayer 3fb99698ab storage - only create DB if path does not exist fd5d3ca54e Update behavior of task reveal === silent (#61477) d00ae9bd38 #55879 Collapse all action for custom views 51a83e467e storage - log duration of SQL schema upon opening DB 0db7f8d853 storage - ensure to flush in sequence and wait for flush queue before closing DB a5017707bf mark some 'contributed' services as supporting delayed instantiation 6c371594a2 remove workaround for #61917 276aeea254 make delayed service instantiation opt-in #61917 d71f741e6c Merge pull request #61859 from YisraelV/master 48e9819164 Fix item lookup (fixes #61663) 07d5e289bb setRowLineHeight: false (fixes #60701) ee0815204c Fix timing issue (fixes #61748) 0d98745507 Merge pull request #61882 from ProAdd-ons/task-v2 17c90f6114 Fix tests ba3c4bcbcb npe in history main service 95fcafdf56 Added a section on the Bundled Extensions a111c5b439 Added common extensions link to related projects (#61446) daefb81397 Remote disable action from viewlet and show it verbose in editor 1abad0e0d0 storage - add more timers to compare 7217a7a513 storage - disable global storage using sqlite for now b5b15c1e6d storage - tweak performance numbers 4626bc0e1b Merge pull request #61965 from usernamehw/align-badge-color 4cb80defdb Fixes #61912: Account for the fact that modes can be instantiated before all extension points have been handled. cdd3c60432 Delete `no-results` class too e78db47121 Add an entry to the search history when the search was triggered by an option change 98fbaad23c Fix search integration test on windows 9bccab9a94 Fix setting description typo, edit for clarity 4a0cba8567 Merge pull request #61978 from usernamehw/link-hover-color 6eca4d1685 Fix search integration test on windows 8cccc98d91 Fix strict null checks 3a50d8c00e Clean up 392acac1de list option: supportDynamicHeights 00ac4904ac wip: list with dynamic height elements 58a8a46eb9 Use hover link color in Settings GUI 1737fde471 Per extension (#60773) d934283873 Skip requests with socketPath (#60773) 2795b98bac Use vscode-proxy-agent (#60773) 5342bf230c Address changes requested by maintainer 09f70a9996 multiline breakpoint widget de3740ae58 Align badge theming with the GUI badge b6d41d7bfa Change 'overwrite' to 'override' in setting screens a2e96753ee Fix build fail in api-tests 813f4aa0b7 Add workaround for #61907 1926da78cf #59458 for editor matches, tests 9a6cd0a3c1 Fix #59458 - implement context options for text search (ripgrep) 26c0e9bb4d Take selected text into account for more markdown snippets 1476540297 Always use splice 221aa3d632 Introduce RequestQueueingType eafe48e901 Adding basic tests for request queue 5919eda976 Move request queue to own file 7363dcca25 Move callbackmap to own file 855d78e8a3 Move ts server into own directory 0f3e07c3cd More explicit types for storage.get with fallbacks 8df9f241e6 Strict null checks 21816902db Fixed typo in comment (#61909) 2c62736bba node-debug@1.29.1 e34c00f63e fixes #61561 36bf69fc87 Merge pull request #61837 from puneet97/patch-1 3cd4aa4ead Fix #61860 - one Match per FindMatch 37fc885eeb Add rg json output typings bcc533fefe Obsolete comment 44a80801cb Fixes #61825: Refactor mode creation 7e102b5de3 Task 2.0.0 2d30bece1d Task 2.0.0 10dc625582 Task 2.0.0 02a65af113 Task 2.0.0 34c9201b29 workaround #61310 4252e67b35 fix one part of #60192 1ac04b5381 Merge pull request #61789 from varanshukla/master cbda7166a0 Ensure that terminal process ready is always fired (#61299) b7fed176f1 explorer: add willResolveExplorer and did ResolveExplorer 422b14feb4 Remove 'new' and rewording 5d68db08cd Combined text search result tests 36d5e04603 Use combined search results for matches from editor, too 7397ec97e6 Multiple match on line integration test aba240a4d8 Fix #59919 - text search combines matches on one line b8c5d97659 Add missing final periods in comments. (#61827) 60cbd1fd0b Allow storage to return undefined fallback values 907924abc0 Reveal absolute top of markdown preview when scrolling to line 0 fe63c7e2f2 Reveal line 0 in editor when markdown preview scrolls to top 295ff96f26 system proxy: use node url to parse url f4131970f6 Add `isRetrigger` field to signature help context 9aa969cd07 Fix #61546. Strict null checks for comment services. 02275f047b Add tslint rule banning new Buffer edefe6b0bf Fix #61744 - remap \u1234 unicode escape sequence 5ad9e9c22e Remove duplicated search helpers a3e49cae31 show the number of hidden frames (Show N more frames) 1e9717afd2 Support collapsing stack frames 4c131e5bc5 another fix for #51013 5c5dafee0f debt - do not use deprecated API 83ecc6ae04 Merge pull request #61653 from natheist/grammar b715dd6c45 Update keybindingEditing.test.ts 76af0df43b Update files.ts 0ebf5f2d5f debt - new Buffer() is deprecated d54b3a0607 Add window.nonNativeFullscreen option for macOS (#55267) e3938ba331 fix build b4490c5aad fixes #58137 1cc7dd4025 setVisible do not lie to the world, you are not async 3dd2b19b2a Use TS 3.1.3 for building VS Code 8bcad6aaaf Pick up new TS insiders version 9375a38648 Fixing editor-distro compile error 4a29bd3731 fix compile 98f26b19af fix strict null 1879561337 grid: pass priority, snapSize and proportionalLayout down to splitview c01cf1d166 splitview: support snapSize 92187cf405 Add null check in setComments 0c6e472c31 fix strict null checks build 0ba2d2bd4b Merge pull request #61757 from Microsoft/rebornix/pendingcomment 949f44e5a3 splitview: LayoutPriority 01651ec8ec Merge remote-tracking branch 'origin/master' into rebornix/pendingcomment 5c888c9720 Remove new pending comment cache 2c777c0fc4 comments contribution takes care of comment fetching itself 2ff5934b85 splitview: proportionalLayout option b2f8941985 Use median instead of mean for measuring terminal frames 092bb9a585 vscode-xterm@3.9.0-beta12 c9f7d10187 Merge pull request #59070 from Microsoft/octref/58555 8c8bec8855 use accessor explictly c7587607ff renamge getcomments to recomputecomments 9b2b174cec debt - fix bad URI.fsPath usage 496ebc6438 let '--prof-append-timers' also append if it was a standard start e3375691ee remove input box visibility change 63da98253c Revert "Revert "Merge branch 'pr/60051'"" 2142a3d02f debt - remove unused 2086ab0fc7 move vscode-chokidar under MS org f21c227349 Make sure to always write with normalized line endings 4823e0e2da Use yellow for monaco.d.ts errors 072eef20ac Show monaco.d.ts output only when something has changed 9deb8d4a42 Read monaco.d.ts.recipe files as needed (don't prepare them up front) 7e8384ba86 Execute just once after N changes c88064a3ad Make sure standaloneEnums have consistent line endings baf8b88b1d Add versioning to monaco.d.ts generation 84bff649af save new comment is hard. 8b0b57ea13 Fix minor grammatical error in menu bar 16a7ded725 delete pending comment cache when comment provider is disposed. 64ec4ed02c reset pending comments when it's being submitted. fa1c682df6 Focus into the textarea when there is pending comments 54c9ebe824 pending comment caching in editor comment contribution 628ac962e2 Fix multi root workspace terminal split 2358502867 Drop console 73d8934c23 Menu horizontal alignment 38ca802368 feat: add push to git extension API d7d97c95bb Snap font stack to latest edeb1acdf0 Remove font-weight change to fix jumpiness 54697b717a Address PR comment 2e5c9f84d5 Make sure a view's parent is not overwritten ab77071aec Give hierarchy to the Open View quick pick. Fix #58555 54f4967761 Refactor SchemaRetryNotification to ForceValidateRequest cb8d482429 Cache JSON schema error files fe4ce0b9d4 Add retry action to JSON status bar icon 7814f38222 Add SchemaRetry notification to jsonServerMain 27ce1616ca Show JSON schema resolution issues in status bar, not notifications 01754ba288 Revert "Use ErrorCode in JSON Language Service schema resolution error handling" ab43e947f7 Only remove actual schema resolution errors from JSON errors 0137ebd471 Use ErrorCode in JSON Language Service schema resolution error handling 157ee8c394 Show JSON schema resolution errors in status bar only f3c7ce2a05 Fix #60002 Undo last commit: keep staged files 3b044e950f Fix #59323 8f86ba057e Less costly comparison 4b4fa8c66d Clarify git prune 373f50a102 Add git.fetchPrune to menus.menus.commandPalette 6cc0f06531 Add git.fetchPrune 01e69df867 Check if the selection is empty 2eebdffae0 Prevent copying an empty string by accident 8d664e47c9 Implement smooth caret animation with toggleable option 1e301ededd Grammar Injection - Consider broader Scopes 8b15044840 added two new commands 1554120b6a Merge remote-tracking branch 'origin/master' into tyriar/snap 2d84224357 Merge remote-tracking branch 'origin/master' into tyriar/snap e11500fed0 Merge remote-tracking branch 'origin/master' into tyriar/snap 9f2511fa8a Merge remote-tracking branch 'origin/master' into tyriar/snap b50f1ec0a3 Add run-agent script for snap package 9d75305b7f Add fix for EACCES socket error ece8157985 Ignore copyright header in electron-launch 474568c55b Merge remote-tracking branch 'origin/master' into tyriar/snap 79b79309ce Call a script on update dc51479d3e Sleep for 10 seconds instead, don't bg 3786b97818 Add doQuitAndInstall impl for snap/linux 588675bbf4 Update dockerfile 7097e0b3da Remove postRefreshHook reference 90385c778b Remove post-refresh hook 32c28382f7 Fix bash var 4bd6c1cf3c Merge remote-tracking branch 'origin/master' into tyriar/snap f002aaec95 Set up auto updating for snap 893714d0ce Merge remote-tracking branch 'origin/master' into tyriar/snap d9fd598afd Fix post refresh hook to use electron-launch 947d563482 Add SNAPCRAFT secret vars 648a5b0869 Fix post refresh hook 99875872f0 Fix hooks dir 79786dcdf2 Add a test post refresh hook 482d882531 Add missing variable 3117032b02 Set IS_FROZEN d34c0805a0 Fix quality condition de6d670301 Build everything again f1233bb94e Auto push and release snap 9609e49398 Add revision to snapcraft version 7d741df2c4 Echo snapcraft vars 9373fb1997 Don't ls dir 5806e7f1b7 Don't look for version fc7b21f627 don't build snap package d338aaaa49 don't build d3e86940aa Login to snapcraft and publish 0bb30b159f Move snap Dockerfile to new dir a18ab37847 Add snap Ubuntu 16.04 dockerfile 26ae1a529f Add release snap that only builds and publishes the snap 17e5119738 Add snapcraft version to snap task 2d1b17d100 Include more stage packages in snap c938bd3736 Publish snap package 195aa35bb3 Remove unnecessar snap deps ede5af3c77 Use correct folder for nvmrc 0434c60b4e Build snap and print folder 43ea0f8f93 Move .nvmrc before nvm init in CI

::SUMMARY:: Branch 965da0535a1a7ba1902230d8a53e61435070ac33 commits: Fix sqlDropColumn description (#4422) Branch merged-base-2 commits: fix build error Merge branch 3cd6d8acc into merged-base-2 Merge commit '0bcf5cff8a0b2298fc6d8dc69825e841d8e57295' into merged-base-2 Merge commit 'ebd187ec069b0521d9b9c6543986127baa354826' into merged-base-2 Merge commit 'b495fb7a373389a4283c91c95de21402779844e0' into merged-base-2 Merge commit '58e5125cdebafd79b69683ce533210cc485175ae' into merged-base-2 Merge commit 'dadfbd2ddbbff39b3cc7c5f7bc7d29bd2d212564' into merged-base-2 Merge commit '9fdeec612868e3e68a3541b1172c9748d2026765' into merged-base-2 Merge commit 'e783aeab66adbf0321ee2a08ed5f8da4eee0a054' into merged-base-2 Merge commit '53a94cc7bb86d2aad9b5f3751a94b647d2c90199' into merged-base-2 Merge commit '839a9b6cb8bebcded4be2154ea213e045946d5f3' into merged-base-2 Merge commit '2557d77ae3d17ef14c5771b7824e99270397ccce' into merged-base-2 Merge commit '6a7df2f1ae17b025f722d735433193bfe53f6407' into merged-base-2 Merge commit '2db83b389214e8a28393a210d66525634ea5dbb7' into merged-base-2 Merge commit '08c7cc09183318422b1dd04b180b1fe8509c82e6' into merged-base-2 Merge commit 'd555dcb6d74bb25e9cac351845ec489ce265aff2' into merged-base-2 Merge commit '7226f25c670384571e9ee8c39b2073493fd50aa8' into merged-base-2 Merge commit '77a3be6fd778050eaad29d7914666ef91be63541' into merged-base-2 Merge commit '2397df7f2296e7366c7bf4978f7f1d2823c301fa' into merged-base-2 Merge commit '118d2c7273a2e82d81426744e3b215bd35942fcc' into merged-base-2 Merge commit 'b44d2b1bb3dc54bae2a0d58bb4089d391f6a6fc7' into merged-base-2 Merge commit '9867d88067afc498f94882ed94105863c5fe951d' into merged-base-2 Merge commit '037c49e2c687c89218dedbffd4712a38d52af087' into merged-base-2 Merge commit '1e989060f91b56fe052bc6f1e27c9fd18d441112' into merged-base-2 Merge commit '4d6271c16147618850ebe5e221efca02992b4eeb' into merged-base-2 Merge commit 'c3900f6984802807908ca97a9fc75ae02279eec2' into merged-base-2 Merge commit 'aa1a036f661c065a067acd5315482baa71f6ea1f' into merged-base-2 Merge commit '26274e6c5d32bc29c0afcd5863ca6e667741612f' into merged-base-2 Merge commit 'bcfbe5a284512381fd9923e1705e0db41bd685b6' into merged-base-2 Merge commit '496243fbc71ff71a7213101bc4acb0cb35f30885' into merged-base-2 Merge commit '036ffe595ae711a08e8554f6f7a6475945221eea' into merged-base-2 Merge commit '2a903e9f0391aa242d18929f9c7bd42fcf5ab12c' into merged-base-2 Merge commit '36e5bbb752904f0f432f64f18fea07cdff122f9f' into merged-base-2 Merge commit '96a976d826eed6454c2a2870038a142b817670a9' into merged-base-2 Merge commit 'ff514a05681582af38fe3904d05469a1387acf07' into merged-base-2 Merge commit 'a4d99b78d59ca7228cc349ff35a3736e86a1ad05' into merged-base-2 Merge commit '029c69ecd39bc4bcbab662bf5d9564c3503d5603' into merged-base-2 Merge commit '9e1f04e476f9400f04bfec72c69690c2208f7903' into merged-base-2 Merge commit 'c8bde4145106dbfc350c5a482cacf5859c49e3fc' into merged-base-2 Merge commit 'e16c01623d65dc9de4718ef23aeda1d6e6fc19bc' into merged-base-2 Merge commit '7de294a58e51f52360b96e3d0ad4afec37d70051' into merged-base-2 Merge commit '060343f096eda85a824dd9646502b62337973f2d' into merged-base-2 Merge commit 'addba0d007019ce7afb773edd3adddcab1b378ba' into merged-base-2 Merge commit '68418f2c8f92786105526fa462b85a1f2c90fac8' into merged-base-2 Merge commit '428dd17d54342b38843630165bfab518ae29c4aa' into merged-base-2 Merge commit '7344b41f474462fcc457230d1d4ba30b67850d2b' into merged-base-2 Merge commit '5f003b0dd7017607de0a13409e798e050b6ea504' into merged-base-2 Merge commit 'b8f454b8' into merged-base-2 Merge commit 'b97740c4e62207301585fb4043f2808cc34d7401' into merged-base-2 Merge commit '5670416e4a18d4f93973ffef2c5878114a2743ea' into merged-base-2 Merge commit '7fa03813f4965cfd274ad0be5381ccd34510f2ef' into merged-base-2 Merge commit 'b368859a2b233407f16adfc94719e5b5033828e8' into merged-base-2 Merge commit '855b33e1f0a8dfa6de69da5bbb807f98225b990b' into merged-base-2 Merge commit '3dbf51cf3ea2e5f055fe43d6f8d5a73aae9c6968' into merged-base-2 Merge commit 'd38c5b86ceb4175f8e37868b91facdb09f011e7a' into merged-base-2 Merge commit '29179eaa23c9c93aede2da1c03e69f9ccf59b4e1' into merged-base-2 Merge commit '1881db074b7a6bacc7c2354db34fbc1de1ad8970' into merged-base-2 Merge commit 'cc8b25b5ada64b976b0573d959b4c347aef86b1b' into merged-base-2 Merge commit '2b8d7248b8165f33395e42fe02a186437b9412c2' into merged-base-2 Merge commit '066ee8c2d7587f7f9596f4c06f433c2e1f089a07' into merged-base-2 Merge commit 'de57829fc38605c4bbe8c9993d242cab7a5922e0' into merged-base-2 Merge commit 'f80971cb610799954e4a1df488847d11bca8ad3c' into merged-base-2 Merge commit '8f36acde0ae97f2c52bbc8c05f781a8e6f85eea6' into merged-base-2 Merge commit '0740633118c88555e139624320ffc4825dade527' into merged-base-2 Merge commit 'd28f895d31bc5e2d445ec643350941257daeb787' into merged-base-2 Merge commit '355b9809debb24ad1f0414fad20e75529db4297d' into merged-base-2 Merge commit '4a7e742fb86e077be3637066c8b73eb0de9834ec' into merged-base-2 Merge commit 'a1d8f25b084d5400f1d60baa11d18bca7ca235b1' into merged-base-2 Merge commit '80db56803277b84a5b168f8915b30571415cc2a7' into merged-base-2 Merge commit '369612899dfa80c4e533757e85fd205089d77003' into merged-base-2 Merge commit '47661d4ec3653b4b6147bef2ff6a7f7e468ea598' into merged-base-2 Merge commit 'cd18eb9be8f4a765d4121e3ef7ed2faf8f50a157' into merged-base-2 Merge commit 'd63ebe3644eb005855a8f3031be7c3d05d71f268' into merged-base-2 Merge commit 'dad8b644821739d2a596887b42b4ee9a9298d849' into merged-base-2 Merge commit '5c298d1f4aada252f9972d7495af2802daa370e8' into merged-base-2 Merge commit '649c0aba5b3ddeec1171d9013b28e94d1c8f3146' into merged-base-2 Merge commit '16114454d5718ee152b7ca81ca2b33088eed8c25' into merged-base-2 Merge commit '0cdd4b12417ee72dc7aa4f1492e499fe07ccc81a' into merged-base-2 merge 0cdd4b12417ee72dc7aa4f1492e499fe07ccc81a Merge commit 'e27511826f363156c616e5facbb60702e40b79f3' into merged-base-2 Merge commit '1054c555b5889e6479544c68357d38d047605969' into merged-base-2 Merge commit 'e42a2a21dab434a81a16aefbec2e75b26030941e' into merged-base-2 Merge commit '533f3dd8a6f7fc7510c374874e84daa9c7413909' into merged-base-2 Merge commit '86adcc7fcfca511b2d5c45a6ca76282e7dad40f8' into merged-base-2 Merge commit '0236c8e7f81245e56f30301163e27bacde5e0356' into merged-base-2 Merge commit 'db8a92f5c278f98e5913c7a44029b6d3ee5473e9' into merged-base-2 Merge commit 'c1e5408492584a2635bf55470c38ca3aea4a0c85' into merged-base-2 Merge commit '84890eb1b4a7cbfd00d07ef8b06078a8f35dca6f' into merged-base-2 Merge commit '220685a522eff0d858630b0139c00936066c64ee' into merged-base-2 Merge commit '8ebf5dbcb4feeae892e0f5ad7193ec7f7e8d6b71' into merged-base-2 Merge commit 'dad807d62d25f76c44dae1deddf42df44a700c1a' into merged-base-2 Merge commit '8e52ffa30e601b0069beec6edc2f25e99c001b16' into merged-base-2 Merge commit '18970ff0b9bfc788ff229ed4e1e81e9ac7e559e3' into merged-base-2 Merge commit '630698459bf0b55369fc3706f3310de36081f583' into merged-base-2 Merge commit 'f8e854a0870a2224a7e3b1a205b26e1fdc4f46bc' into merged-base-2 Merge commit '3b2274b0aa32fb4c433471481fd3fd18fbc46621' into merged-base-2 Merge commit '0d1ebce1a1ba6cc8a1fe9feadcd0d90f4cbd2536' into merged-base-2 Merge commit '70d86ce9a256bf7e44eb6efc6a83bd9ff46372f8' into merged-base-2 Merge commit '291f591af3421899481725016ccb08a40424c036' into merged-base-2 Merge commit '5a48c52a95a2356dc84275e6ab5a58af6fecfc7c' into merged-base-2 Merge commit '5625ef956d1a0e75891b5fc30b68c00ff5250b15' into merged-base-2 Merge commit '969733ab7763f938499ec635c70fdd51c2d234e0' into merged-base-2 Merge commit '12a1ac1a7d667d1bbb8752f61c893d2fab1a6115' into merged-base-2 Merge commit '4da322a03f60abfd48d03f70c413fe4d3c6cd6ae' into merged-base-2 Merge commit 'd5754c00e200ebb0c2b20e3b679f00fe242f730f' into merged-base-2 Merge commit '2e9b5f3a2b0a5095b14631937134a12765ddcb6f' into merged-base-2 Merge commit 'b11a8e9c0cfe98eb291658f17b34db60896b097f' into merged-base-2 Merge commit 'e37533afbb43753c8657106012b9a2f0ae2aba52' into merged-base-2 Merge commit '4a476673ac3c210c2561dacbb52af7ed10fa405e' into merged-base-2 Merge commit 'fe5386cc08db8da41010c802a737e7f4cf31258c' into merged-base-2 Merge commit '8bfb1a9d3926a97231f96ec5492aaff196e1cb89' into merged-base-2 Merge commit '109aafcbc0474992bd394056946bc7a480be0349' into merged-base-2 Merge commit 'e289c06d8d149333beb538c73d76e7397bfcf49c' into merged-base-2 Merge commit '78c1c318c59d2750fc745e69474dd1ca86147187' into merged-base-2 Merge commit '07983d75eab418a23b1b2348701ec781b125ee24' into merged-base-2 Merge commit 'd0a4a4242d410967fe67387262bc650bcbb2bb1e' into merged-base-2 Merge commit 'a71be2b19365a4b56adfa6f1dd81713aa9f46b06' into merged-base-2 Merge commit '779ca13d489a29b14c7e6c649e3af3e9aa6f896f' into merged-base-2 Merge commit 'f3b0a50db7d39f612b9cd99b62473e9a36b16f84' into merged-base-2 Merge commit 'c831596e0258aceca2ea4647d2fa2420860f6217' into merged-base-2 Merge commit '2ae369fbdb3b795b384b4719c77cc3694dc7a256' into merged-base-2 Merge commit 'f2c9d968a46827e2808a9ebd1fb47e418c403dd0' into merged-base-2 Merge commit 'c3f02980a0e03c637aafe028bab76ef737d738ab' into merged-base-2 Merge commit '7d5ce7b5d77c81a6667522bb8ecc88bc08879516' into merged-base-2 Merge commit '8bb71eeb51b91aaf68a0cc4897f8b94ebe263d93' into merged-base-2 Merge commit '5a88598811e4d82fb15bc3aab52b6f3d2519750b' into merged-base-2 Merge commit 'da3fbd386d1454b104969e83f589f6fdeb5badce' into merged-base-2 Merge commit '1e915aad2039c06914ca907d23b65bf1fefd29b1' into merged-base-2 Merge commit '889d5e5b28e397680be8cca5bfb4b4ed61da581d' into merged-base-2 Merge commit '51cf2df2f8e5c30ca83c5b410898ae69e04fd545' into merged-base-2 Merge commit 'e690285d9d4c42a0047093b447b555b0e3921484' into merged-base-2 Merge commit '81d6423f241fede9410bd53f8aae7e1a098f63d1' into merged-base-2 monaco change Merge commit 'a33a24dddfc65111828dc8df867eb14d27e1b89d' into merged-base-2 Merge commit '0ab3492afdbe21b9cb89a7d639770b124dc54e51' into merged-base-2 bring in line with ads Merge commit 'dea8705087adb1b5e5ae1d9123278e178656186a' into ads-1301-vscode Merge pull request #65315 from Microsoft/versionBump Bump version Merge pull request #65143 from Microsoft/roblou/fixSearchCancel Merge pull request #65141 from Microsoft/roblou/fixCRLFmultiline Fix #65084 - queue searches so they can finish asynchronously, just one at a time Fix #65120 Merge pull request #65114 from Microsoft/octref/64993 Fix #64993 Merge pull request #64880 from Microsoft/joh/fix/64829 Merge pull request #64870 from Microsoft/isidorn/treeNavigationKeyboard Fix broken Debug > Start Debugging global menu action, fix #64450 (#64860) generate list styles for references tree, #64829 treeResourceNavigator: fire onSelection also for keyboard events Merge pull request #64803 from Microsoft/joao/release/1.30/fix-64739 fixes #64739 Merge pull request #64790 from Microsoft/joao/release/1.30/fix-64735 Revert "list: right click should not select/focus" Merge pull request #64783 from Microsoft/joh/fix/64654 Merge pull request #64785 from Microsoft/joao/release/1.30/64747 fixes #64747 properly cache current revealed reference add pop/shift to linked list Update to Electron 3.0.10 (#56149) Remove code that duplicates Array.join from runAutomaticTasks.ts ignore errors after DA has been stopped; #63640 window - have a getter for window being focused or not Replace TPromise.wrapError with Promise.reject fixes #64503 Remove TPromise.join from task.contribution.ts storage - enable global storage, disable workspace storage migration (#64719) Remove TPromise.as from task.contribution.ts TPromise > Promise (#64598) remove TPromise remove TPromise.as remove TPromise.as debt - more lazy service contributions Merge pull request #64717 from Microsoft/joh/fixmem don't listen to storage changes for now Revert "Revert "remove `shareSuggestSelections`-setting for now #62365"" remove TPromise remove TPromise remove TPromise Revert "remove `shareSuggestSelections`-setting for now #62365" remove TPromise.wrapError remove TPromise.wrapError remove TPromise.wrapError remove TPromise.wrapError fix compile issue Merge branch 'master' into joh/fixmem :lipstick: insta - actually enable delayed instantiation use bracket/block selection ranges provider, fixes #64272 add leading/trailing line part to bracket selection #64004 update references view extension storage - beforeClose() is actually not needed No horizontal scrollbars after toggling side by side diff view (fix #64090) debt - dispose action items that are pulled from actionbar no tabs - prevent title from exceeding 35px height Update calendar Merge pull request #64715 from Microsoft/joh/brackets Merge pull request #64619 from Microsoft/rmacfarlane/git-apply take max 4 * 30ms notifications - push initial notifications out a bit to give editors more time to restore telemetry - double it up Update commands.yml reject if gallery is not enabled #64597 Move away from TPromise #64597 Move away from TPromise debug issues to isidor outline - remove unused css Strict null check serviceMock Strict null check patternInputWidget Working on strict null checking contentHover Prefer coalesce over filter Strict null check contextScopedHistoryWidget Strict null check format action Strict null check findOptionsWidget Marking fields readonly Strict null check findInput Strict null checking inputbox Strict null check panel.ts Use more DRY class definition Strict null check composite Fix formatting for TS 3.2 Strict null check configuration service Strict null check auto adds Enable strictBindCallApply for VS Code Build VS Code using TS 3.2 :lipstick: Use undefined instead of null Add toOpenedFilePath method Never return undefined for cachedResponse.execute Extract cached response to own file schedule update overflow action due to reflow (#64634) (#64639) schedule update overflow action due to reflow (#64634) Remove TPromise.join #64598 Remove TPromise.as - #64597 Remove TPromise#wrap calls #64596 Avoid accessing style in treeview if we don't need to (#64577) Bump to 1.31 Add GitErrorCode to apply command Merge pull request #64558 from marchenko-am/marchenko-am/fix64379 Merge pull request #64243 from Microsoft/tyriar/63688 Merge pull request #64560 from Microsoft/tyriar/null_check_initialCwd Merge pull request #64611 from Microsoft/tyriar/64598 Allow users to enable/disable automatic tasks (#64615) Convert backup tpromise.join to promise.all yield when computing bracket ranges fix bracket selection issues Update commands.yml Add task names to automatic task notification Fix results lost from FileSearchProvider when maxResults is returned Remove workaround for ts infer type suggestions showing up with no quick fix Pick up ts 3.2.2 Cache document symbol navtree requests Prevent default on mouse down (fixes #64350) Add a null check for initialCwd initialize focus state fixes #64500 #64557 Do not hide tree also when tree is being refreshed Fix #64557 Make LogLevel converters safer and consistent with other converters, from @jrieken feedback Fix #64379 - SimpleFindWidget position was changed (in hidden state) for shadow hiding Revert #54397 fixes #64463 use findNext/PrevBracket for bracket ranges only Promise.reject in configurationResolverService should return an Error Update commands.yml Regression: cancelling a launch command should silently cancel launch Update commands.yml Update commands.yml Add '/needsConfirmation' Don't show tasks output on auto task or config change (#64543) protect input variable resolving against undefined mapping; fixes #64542 fixes #64398 repl: reveal last element when session change repl: simplify id computation for simple elements disable listener leak monitor for stable, #64493 Add launch section to support input in launch.json remove `shareSuggestSelections`-setting for now #62365 make suggest memories a singleton service, listen to storage change events debug console: polish height computation Tasks with presentation clear: true and no other presentation options should clear Merge pull request #64496 from Microsoft/ben/62365 suggest memories: restore saving state periodically (for #62365) fixes #63957 fix #64319 #64319 tests one more to dispose (for #64470) fix telemetry annotations Make sure we dispose of created context key (#64471) Fix #64120 - avoid triggering listener leak warning Fix strict null check Show prompt when closing issue reporter without submitting, fixes #64462 Wording tweak Don't capture first line of @example blocks as js/ts Better end of line match Use more restrictive regular expression for markdown jsdoc content Fix #64273 - EH log levels start at 1 Improve retrigger documentation #62365 - use markdownDescription and setting reference fix GDPR annotations add link to wiki page, #64340 Inputs should not re-prompt on tasks set to not reevaluate variables Revert "#61590 Change the title" Fix #64331 - relayout on search height change update ref-view extension fixes #64439 fix #64437 fix dirtydiff listener leak fixes #64320 fixes #64400 fixes #64399 debug: remove baseDebugController, no longer used node-debug@1.30.4 use final version 1.33.0 of DAP async data tree should update twisties accordingly fixes #25281 fixes #60995 Fix #62411 (#64433) Update allow automatic task notification with feedback Fix broken config resolver unit tests Fix #62477 put breadcrumbs on their own row (#64364) show a warning instead of info, #64353 avoid confusion and use 'operation' instead of 'task', #64353 remove keybindings for declaration commands, #64329 Cancelled inputs should cause task to end silently Make Alex R. responsible for tasks Should not silently ignore undefined input variables Improve descriptions in input schema fix #59439 Make task input pick and prompt more specific fix #64339 Change task input label to id #61590 Change the title Fix restoring pending comments, fixes https://github.com/Microsoft/vscode-pull-request-github/issues/718 Match signature context field name to type name Hide infer type suggestions when using broken versions of ts Add typings for markdown preview messages Fix markdown fragments when opening file in workspace Correctly highlight @example code as js/ts Revert #62806 Ensure expected decimal separator in ps output when listing processes, fixes #63437 Bump distro, update OSS Fix/64292 (#64365) update title #61590 Update title :lipstick: Right fix #63496 #63496 rever escaping debug: support input schema in launch.json editor - cleanup tabs title control (a bit) Fix #64341 Fix undefined error in inputs configuration resolver Fix PCRE2 description Intelisense on tasks.json is broken fix #64309 Revert "Make menubar its own widget and add overflow (#63954)" Small fixes to sig help context docs Merge pull request #64271 from cleidigh/selectbox-sticky-off/bug SelectBox: Restore _sticky = false. Fixes: #64265 Make sure our temp ts directory really exists Fix #59922 - changes needed to support a cache in a FileSearchProvider Give extra padding for simple find widget Revert "call resolve before inserting a completion item, #63013" Rename TriggerReason -> TriggerKind Bump node2 Set default terminal buffer impl to TypedArray Naming (#60773) Copy options disable by default (#60773) tweak jsdoc Merge pull request #64224 from skprabhanjan/fix-64041 Experiments shld provide local text for commands too (#63261) remove sample function proposed api finalize tracker API; fixes #62843 Improve ext host terminal proc hot exit - do not clean backups when quitting before editors have been restored Fix #63906 fix strict-null fix-64041 - Changed ParameterInformation constructor - Changed @param label description Fix #59497 fix-64041 - Changed ParameterInformation constructor handle ipc-queue cancellation, #63013 Fix #59481 call resolve before inserting a completion item, #63013 Make menubar its own widget and add overflow (#63954) Merge pull request #64093 from Microsoft/mjbvz/63013 Merge pull request #64200 from Microsoft/isidorn/zenModeRestore zen mode: properly clear state on shutdown Merge branch 'master' into isidorn/zenModeRestore fixes #62629 storage - include a WillSaveStateReason when saving fix #63431 strict null for all smart select smart select bracket pairs, #64004 Fix #64199 Merge pull request #64007 from DustinCampbell/update-csharp-grammar Fix opening settings editor when ui is disabled Merge pull request #64189 from usernamehw/keybindings_command Remove support for post install debt - remove editor history listeners when condition is met ensure a range contains its previous range, #63935 zen mode: We will not restore zen mode, need to clear all zen mode state changes tests and api command for smart select api, #63935 add proposed api for smart select, #63935 Added commit hash to cgmanifest.json missing compilation storage - parts splash becomes a window config to show early on Merge pull request #63947 from Thomas-S-B/master only show update service errors when asking explicitly :lipstick: Merge pull request #63759 from donaldpipowitch/patch-1 rename setting, #62365 Merge pull request #63193 from skprabhanjan/fix-62365 keybindings - do not steal focus from an event Remove Better Merge key #64190 perf - measure workspace service init time as well update ref-view extension Automatic tasks should prompt before running (#64075) Input variables in tasks (#63910) log provider failure as errors, #63831 Use string type for `command` property [fix] #27649 pin intellisense documentation widget to top (#62115) Fix search/replace unit tests Fix F4/shift+f4 for search result list causing hang, due to native promise switch Fix #64112 Make _actionRunner non-nullable Fix completions for intellicode Fix snippet function call completions for intellicode Strict null check platform/configuration/node Strict null check menubarService Strict null check checkbox.ts Strict null check action bar Fix event typings lifecycle - allow vscode:openFiles in Phase.READY storage - :lipstick: storage - :lipstick: storage - dispose some listeners on close already storage - avoid storage access on shutdown storage - add beforeClose() to tests storage - do not force a 100ms wait on shutdown/reload fix strict-null check Merge pull request #64110 from Microsoft/ben/global-storage storage - handle telemetry global keys storage - reduce global storage change events for testing only storage - add tests for mapToSerializable Merge branch 'master' into ben/global-storage Strict null checking snippetsService.ts (#63456) Strongly type some event types in addDisposableListener Strict null check Strict null check Type objects.assign Strict null check extension scanner Strict null check menubar Fix QB tests, #63049 Fix #58035 Move signature help context to stable api Fix #63049 Do not cache completions that are cancelled during resolve Fix #63488, search layout issue Support debugging process from the process explorer, closes #63147 (#63953) Add panel/sidebar nav commands to skip shell default Fix #62304 - allow copy/search with multiline text Move isSmartCase off IPatternInfo Bump node-debug Fix #63297 fix tests debt - use Set for cloneAndChange another fix for #62719 fix #62719 Merge branch 'master' into ben/global-storage storage - put migration behind flag green build maybe? Merge branch 'master' into ben/global-storage fixes #63416 storage - better check for migration Automatic tasks should prompt before running strict null checks fixes #63939 fix async data tree expand promise debug trees: minor polish add word based provider #64004, add multi-provider merge logic #63935 Explorations Fix #64061 debug watch: Ignore double click events on twistie debugHover: disable mouse support and fix focus Move rerun behavior api out of proposed (#63511) list onDidChangeContentHeight final tracker API; for #62843 Add monaco.d.ts More strict null checks (#60565) Strict null check for simpleServices Make strict null check automatic storage - fix smoketest storage - add global storage migration Fix task shellConfiguration schema strict null... repl: disable mouse support list: improve lack of mouse support continue builds when component detection fails repl: Align twisite to last line - for input output pair expressions callstack: ignore erros from tree when expanding possible unexisting seassion and thread async: ignoreErorrs only blame an extension once... uri tweaks in md strings Merge branch 'master' of https://github.com/Microsoft/vscode Global tasks don't need a workspace root - Remove proposed api check for collpaseAll - Add proposed api check for treeview message and globalStorage Enable Collapse All action in the npm script explorer Fix last merge conflict warnings remove unused code ftw fix #64052 Pick up TS 3.2.1 final Add pinning test for bracket completions Added test for #63100 Extract joinLines Merge pull request #64010 from Microsoft/rebornix/commentsgrouping Correctly sort bracket accessor completions in js/ts completion list Don't trigger parameter hints when completing empty method Update js/ts grammar better handle of labels Support whitespace after dot for bracket completions Delete unused typings file remove unused method Center add comment decoration, fixes #63810 Merge remote-tracking branch 'origin/master' into rebornix/commentsgrouping comment thread can be updated by draft mode change. Add overview ruler decoration for comments Update C# TextMate grammar with latest fixes lifecycle - put some things back to RESTORED phase move token tree provider around, #63935 debug hover: use WorkbenchAsyncDataTree debug console: Reveal last element when we add new expression Fix 63749 - Markdown, U+2028, and "Go to Symbol in File..." (#63936) Merge pull request #64000 from Microsoft/isidorn/debugTrees callstack view: expand is async variables view: Expand the first scope if it is not expensive and if there is no expansion state (all are collapsed) storage - implement external changes add simple filter for LoadedScripts view cleanup #60053 hide message when reload is disabled Merge pull request #63187 from Microsoft/ramyar/reload-subtext callStack, repl and watchExpressions provide identityProvider Merge branch 'master' into ramyar/reload-subtext Fix #62917 :lipstick: Fix #63906 Merge branch 'master' into isidorn/debugTrees async data tree: recursive refresh Fix #63928 fix #63977 identityPorivder for variablesView Merge branch 'master' into isidorn/debugTrees Fix #63992 Merge branch 'master' into isidorn/debugTrees reveal reference after having revealed it... fix #63978 list: right click should not select/focus async data tree: preserve collapse state given identityProvider tree: more type cleanup tree: cleanup null vs undefined async data tree tests: add refresh button objectTreeModel preserves collapse state on strict identity async data tree: :lipstick: async data tree: :lipstick: storage - log close() duration for global main fix regression from data tree adoption, #63904 storage - log global storage home storage - use storage service also for global Revert "explorer do not always reaveal in middle, jump less" remove call to post install fix tests storage - trace close() time fixes #54397 storage - also log time it takes to init global storage in renderer Fix #63710 smart select - skip duplicated ranges smart select - simplify model, fix some issues storage - remove unused storage - properly implement global storage Merge branch 'master' into ben/global-storage Fix #63968 #23251 Clean up extension storage location Fix undefined error in runAutomaticTasks update vscode-ripgrep remove unused variable lifecycle - introduce onShutdown event for disposing things after onWillShutdown Skip localhost (#60773) Merge branch 'master' into ben/global-storage Use insertText as filterText for js/ts completions by default use simpler typeof check Update js/ts grammars Merge pull request #63958 from Microsoft/octref/web-component html.experimental.custom.tags/attributes for Microsoft/vscode#62976 Fix quick input list null reference exception render pending label as italic render pending comment Highlight some basic markdown elements in js/ts fenced code blocks remove deleted file from strict null check list Pick up updated markdown grammar Fix npe for draftMode Fix shared process launch config Removed unnecessary cast Bump ripgrep to fix #63070 Merge pull request #63792 from vim88/fix_typo_in_comments Bump node2 object tree: todo add internal api for selection ranges provider, #63935 merge master Merge branch 'master' into isidorn/debugTrees object tree model: preserve collapse with identity provider Support for automatic tasks (#63695) #61312 Revert to proposed Fix #62370 merge master async data tree: proper options mapping fix strict null checks tree options: collapse by default repl: use scheduler and smaller timeout don't write profile too early, apply pii massage adjust wording, add report issue from silent perf notification don't resort extensions after profiling #23251 Expose global storage path in proposed API Fix tests callstack fix npe tree: :lipstick: move types around repl: do not return undefined for hasChildren AsyncDataTree comment out identityProvider due to build error merge master fix datatree.getNode() repl: getVisibleContent wip remove duplicated switch case adopt DataTree in references widget, #63904 list: fix scrollable element delayed changes list: proper identity provider Simplify test running Fixes #63822: Keep tokens for empty lines if the language id is not the buffer language id repl: auto scroll when last element is visible tree: expose renderHeight make debug content updates cancellable; for #41362 refetch Source content on changed events; fixes #41362 #23251 Post extension install hook Task schema issue: dependsOn not permitted Merge branch 'master' into isidorn/debugTrees dataTree: expose scrollTop and scrolHeight Merge branch 'master' into isidorn/debugTrees data tree: use proper loading expose scroll height expose DataTree.getNode data tree: expand should be async repl: minor optimization to reduce relayout calls repl: clean up css and fix widths calc tree: fix renderers type tree: use null to represent root debug: adopt to the click outside of tree fix strict null checks fix build Merge branch 'master' into isidorn/debugTrees treeResourceNavigator2 debug tree adpot WorkbenchDataTree list: emit mouse events on root Merge branch 'master' into ben/global-storage merge master Tweak lifecycle phases (#63899) WorkbenchDataTree history - increase limit (fix #63853) fix tree tests swallow cancellation error in datatree Merge pull request #63716 from Kedstar99/master Merge pull request #63750 from davidbailey00/patch-1 Persist replace input text - fix #63886 Do not display errors in editor for cancelled js/ts code lenses Interupt TS references and implementations requests Revert "Delegate js/ts code lenses back to vs code" Fix #63685 - fix search input heights on panel resize Pick up new TS insiders first cut Interupt geterror requests for signature help requests Interupt geterror requests for getting completion entry details Strict null check selectBox Move base/node to use include instead of files Strict null checks Fix strict null check Fixes #63405, Issue Service: handle null for BrowserWindow.getFocusedWindow() Add keyboard shortcut to close Issue Reporter window, fixes #59845 update json hover for word pattern. Added failing test for #63749 Add skipped test for #63822 Adding version info for ts non-code dependencies Use switch case :lipstick: Extract display part kinds to constants files :lipstick: Move snippetForFunctionCall to own file Extract append joined placeholders Try splitting up parameter list extraction from snippet building Make it clearer that insert text snippets override the rest snippet generation Fix bug for generating snippet if the object type contained a method signature Fix bug where return type containing function type could be merged with normal parameters Adding pinning test for inline types Adding plnning test for rest paramters Adding pinning test for getting parameters Adding basic pinning tests for insert text Add test for using insert text Extract snippetForFunctionCall so that it can be tested add timeout for getmac (#63815) Fix search smoketest Restore #63457 without #63834 break tweak running extensions view, nuke the chart, tweak messages #12764 Show the time of update Fix #63814 - add "Don't show again" option to PCRE2 hint repl: getHeight for elements Fix #63845 repl: adopt to new tree first steps storage - scaffold a basic global storage service on the main side Merge branch 'master' into ben/global-storage #14034 Support installing specific version #14034 Fix actions #14034 Only get compatible versions #12764 Use quick pick object #12764 Install another version action on extension Use thenable #12764 :lipstick: dispose dropdown actions #12764 Show extensions viewlet when installing #12764 Add install previous extension version action #12764 Support installing an extension version in workbench #12764 Support installing specific extension version #12764 - Get all versions from gallery - Ability to get a compatible version from a given version of extension LSV: support 'changed' event; fixes #41362 only set nodeCachedData-prop when having a dir, #60332 adopt new loader, make sure each loader instance has a static seed so that filenames don't conflict, #63605 add identity provider (for stable selection and expansion) fix security vulnerabilities add tryToExpand lookup sources only once less TPromise.join, #53526 know how effective the silent notification is, #60332 don't fire context key change async debug trees: clean up css lifecycle - avoid a will-quit listener fix #63216 Revert "fix #63216" Merge branch 'master' into isidorn/debugTrees loaded scripts: remove unused imports node-debug@1.30.2 fix keybindings conflict #63448 cleanup ids, #63448 update ref-view extension :lipstick: debt - remove unneccessary cast fix bad listener wrapping in closure rename main storage fix compile lock event-stream to 3.3.4 in package.json Revert regression in search viewlet Merge branch 'master' into ben/global-storage storage - polish logging storage - implement async shutdown support Cleanup new setting description Merge pull request #63457 from IllusionMH/search-actions-align-option-61532 finalize DebugAdapterDescriptorFactory API: fixes #62977 Terminal process request improvements Terminal issues to me Fix #63146 Scroll-y menus (#62819) Fixed checkForSnapUpdate in updateService.linux.ts to use environment variable to identify snap path fix menubar focus trap (#62869) Fixes typo and occurrences of double words in comments. storage - update global storage file name storage - pick less obvious file extension storage - rename storage DB to ensure proper migration Test system proxy config (#60773) simpler API use, #60332 DataTreeResourceNavigator simplify debug hover tree layout Cache proxy only per scheme://host:port (#60773) Let settings and environment variable win for compatibility (#60773) Merge branch 'master' into isidorn/debugTrees fix strict null checks DataTree.onDidResolveChildren Merge branch 'master' into isidorn/debugTrees tree: expose things for debug Merge branch 'master' into isidorn/debugTrees debug hover do not leave 10px for horizontal scroll for now data tree: update nodes map fix strict null checks show a silent notification for extension frezing for 5secs and more #60332 propagate userenv to shared process callstack stop throwing Merge branch 'master' into ben/global-storage some lifecycle :lipstick: fixes #63693 first cut of LoadedScriptsView based on new tree some :lipstick: debug callstack: if there are no sessions there should be no children notifications - add silent option Merge branch 'master' into isidorn/debugTrees publish to vscode.d.ts debt - less TPromise check for unresponsive profile when reporting an extension issue, #60332 tweak interfaces, #60332 fix warning message, #60332 Merge branch 'master' into ben/global-storage fix last TPromise ctor use (#62716) fix scm input box nudge fix #63765 show blocking extension in editor, #60332 TPromise => Promise (#63768) fix #62833 fix issue with binary status not updating properly added .hintrc and moved .babelrc to jsonc grammar Fix missing file search 'rg' log Remove StartupWMClass from URL handler desktop file bump distro wip finalize DA & Tracker Debug APIs Break up ExtensionService into multiple files Fix strict null check Nicer single line search input sizing Cache proxy resolution (#60773) Add a couple RipgrepParser tests Text search perf improvement for long lines/multiline results QueryBuilder should respect isMultiline passed in debug: callStack use the new tree Fix strict null check in updateService.snap.ts Fix #62334 Rename interfaces in taskConfiguration.ts to remove duplicates debt: remove TPromise from update Fix #62821 Fix tests Fix broken variable resolve (#63692) #56649 Add detailed assertions update references-view extension Rename to not have two different RunOptions MenuItemActionItem only listens to alt-key when having an alt-command lower general listener leak limit to 100 have high listener leak limit only for those emitters that are used by the ResourceLabel, #63655 debug trees: take care of todos #62370 Improve hover UI storage - first cut hook main storage into app tree: expose visibleNodeCount storage - viewservice.*.enablement state is no longer used, exclude from migration storage - add perf marks for main side storage init Use an event to build resolver cache debugHover: use new tree DataTree: expose domFocus and onDidChangeCollapseState variables view use the new tree Merge pull request #63594 from JeffreyCA/smooth-caret-fix Strict null checks for Task in extHostTypes storage - add a main side storage service some :lipstick: in main Fix #63606 Fix #63623 remove TPromise from editorPart (#62716) Support updating localization extensions from files on disk fix warnings :lipstick: increase timeout for #63434 fix window - convert to Disposable make sure to reset context key completely add proper equals check to resource context key, #63656 :lipstick: Fix #63638 Fix #62768 make deprecated ctors less prominent more strict null issues fix strict null issue update monaco.d.ts write profile to disk and log filename, #60332 debt - use native promise for pfs#whenDeleted Merge pull request #63477 from desaianuj/patch-1 adopt IExtensionService#getExtension only report telemetry when being able to blame an extension add IExtensionService#getExtension fix #63000 debt - remove stacks when removing listeners watch expressions: fix some types Merge pull request #63651 from Microsoft/ben/storagehint fix #63650 storage - do not wait for init when storage is known to not exist storage - fix tests dispose listener #63467 use editor mouse listener instead of multiple listeners #63467 have just one editor config listener #63467 :lipstick: storage - handle strict null remove unused and duplicated code storage - move meta data into storage service too update references view extension storage - move workspace folder and migration handling into storage service watchExpressions: set display back to initial, not inherit watchExpressions: rename box should be inside expression container watch expressions: rename box debug: watchExpressionsView use the new tree debug type polish CollapseAction2 for the new tree Merge branch 'master' into ben/storagehint further fixes to Microsoft/monaco-editor#1199 Merge pull request #63572 from karanisverma/dev fix #63291 fix issue with double menubar with unity Allow editing multiple lines of text in the search view - fix #62304 Log proxy resolution (#60773) Merge branch 'master' of https://github.com/Microsoft/vscode into dev storage - add a hint for speeding up Storage#init() fix strict null checks fix: fixed issue with strict null check fix dropdown! Apply smooth caret setting immediately after setting change storage - handle case where DB is null when closing fix compile storage - ensure to close DB on error update references view tree: expose onMouseClick and onMouseDblClick storage - remember if workspace storage folder was created or not rename isOnlyDevelopmentDependency to developmentDependency fixes Microsoft/monaco-editor#1199 simplify DataTree getChildren make tree events simpler by not exposing nodes fix: returning undefined to ensure the default value is applied Merge pull request #63565 from Microsoft/sandy081/fix63490 update references-view-extension storage - bump telemetry ID again fix: #55946 Added comment snippet variable storage - implement backup solution escape message add comment to vscode.debug.activeDebugConsole; fixes #63489 Fix #63490 Fix #63496 storage - easier tracing configuration Remove TPromise from terminalTaskSystem.ts (#63562) perf - storage should only be in trace mode if enabled (!) Merge pull request #63514 from desaianuj/patch-2 bump vscode-sqlite3@4.0.5 Merge pull request #63508 from Microsoft/alexr00/clearAPI fix build bump vscode-sqlite3@4.0.4 Clean up unused empty workspace storage folders (#63554) Merge pull request #63341 from eamodio/fixes-markedstring-href-encoding #23251 Install post install hook Fix #63128 fix tracker problem on restart; fixes #63529 fix strict null error for debug emit debug activate events in parallel Remove no longer needed license override Update ThirdPartyNotices fix spelling of "firstPage" polish cgmanifest.json Use monospace font for hovers add some commit hashes and versions to cgmanifest.json introduce 'onDebugAdapterProtocolTracker' activation event Fixes Microsoft/monaco-editor#1196 Move clear API out of proposed storage - bump telemetry id Remove no longer needed license overrides Tweak explanation Remove unnecessary licenses bump vscode-sqlite3@4.0.3 Merge pull request #63497 from Microsoft/isidorn/cgmanifest delete OSSREADME.json Revert "only run component governance" Fixes #63458: Restore stable mouse wheel logic Merge commit 'refs/pull/61454/head' of github.com:Microsoft/vscode into pr/61454 Merge branch 'pr/61454' improve dropdown menu placement for sidebar parts Merge pull request #63329 from vbfox/patch-1 Merge pull request #60104 from mathiasvr/fix-60002 :lipstick: Merge commit 'refs/pull/59735/head' of github.com:Microsoft/vscode into pr/59735 Add a rerun last task command (#62645) representation instead of presentation Use reloadAction.onDidChange to set the text Show Reload full text as sub text Fix #63295: Refer to Sudo in Linux Save Error Message (#63394) Always dispose of DecorationCSSRules Make CachedResponse generic Move getSymbolRange out of class Remove extra conditional Remove un-needed any cast Mark fields readonly Don't cancel signature help until next real trigger Always cancel parameter hints on retrigger Use delayer for paramter hints trigger Use hasModel Remove unnessisary conditional Enable loading indicator for subsequent js/ts project loads Extract loadingIndicator to class Extract lazy activation logic Debug API: add registerDebugAdapterTracker Extract to a method Improve labels Add API so that extensions can configure TS Server plugins Always display count badge near file/folder Option to specify actions alignment in search Strict null check configureSnippets Stric tnull check snippetCompletionProvider Strict null check smartSelect Strict null check snippetsFile.ts Strict null check environmentService Strict null check snippetVariables Strict null check formatting edit Strict null check chokidarWatcherService Merge branch 'master' of https://github.com/Microsoft/vscode remove toggle menu bar from mac menu fixes #63436 Temp fix for go to definition not working Add metadata on completions accepted api :chore: add todo fix monaco-editor#1156 fix #61899 debug: bring back clear console to command palette Merge pull request #63328 from sbatten/fix/62984 Check for ui extension while installing vsix fix #63185 notifications - fix TS warning fixes #63416 Rename adopt DAP attribute "runInTerminal.shellProcessId"; fixes #63434 Fix #63433 fix #62587 Use file system service (#31450) :lipstick: debt - introduce and use in-memory storage for standalone editor Merge branch 'pr/62052' strict null checks list: finish dynamic height :lipstick: diag - include OS in about dialog Merge commit 'refs/pull/62052/head' of github.com:Microsoft/vscode into pr/62052 Optimize parseStorage (#62805) #62795 Add proposed api to render description of a tree item Fixes #62981: Adjust constants update DAP introduce git.openDiffOnClick git.postCommitCommand Remove unused import Fix: `foldersChecked` declared in wrong scope (#31450) fix strict null checks rename tfs to azure-pipelines remove winjs tpromise from async fix smoke test use native promises in paging.ts use native promises in Tree Limit to application scope (#31450) Better readability for util.ts Fix #62861 (Proper fix) Fixes stupid mistake :disappointed: add posinset to menu items fix #62007 Adopt OSS tool re fix microsoft/monaco-editor#1013 Fix TreeViewOptions comment markdown remove centered layout from layout menu Merge branch 'master' into isidorn/cgmanifest Check in composite bar for previous existence Revert "Rename placeholders to cached" replace ossreadme with cargo.lock remove build/win32/OSSREADME.json Fix can't click and drag to select text in the Debugger "Watch" pane Rename placeholders to cached Revert "Rename placeholders to cached" Rename placeholders to cached Should not have added the check cgmanifest: npm versions fix tests only run component governance add cargo.lock some tests for #62906 cleanup TPromise from sharedProcessMain.ts cleanup TPromise in sharedProcess.ts fix smoketest: find all references cleanup TPromise in driver.ts cgmanifest npm dependencies Fix #63019 set outline label for TypeScript and launch.json, #62839 naming and doc tweak for #62839 Merge pull request #63150 from YisraelV/customNameForOutline fix #63216 strict null work in extHostTypes, #61543 Revert "strict null work in extHostTypes, #61543" Prepare testing system proxy settings strict null work in extHostTypes, #61543 #61312 Implement message for tree views rename add commit hashes for Joaos hipster dependencies add repositoryUrl to build/win32 cgmanifest, somehow got skipped Debug API: add DebugAdapterExecutableOptions; for #62977 cgmanifest: some commit hashes set revealTop to 0, #63245 add keepWhitespace-flag to completion item, #62057 log telemetry event when we report unresponsiveness and crash, aftermath for #62970 and #62829 use random port #60332 make declaration provider api stable, #62483 actually wire in go to declaration and peek declaration, #62483 Merge pull request #63069 from Microsoft/rmacfarlane/gitapi :lipstick: Merge commit 'refs/pull/63142/head' of github.com:Microsoft/vscode into pr/63142 Can be undefined (#63033) Refactor extensionTipsService for better readability Comments for suggest widget Remove unused method getAllRecommendations() Comments for different extension views Remove is Simplify data2String Delete unused log level and type levels Make sure we dispose of pluginManager Don't eagerly construct surveys Move survey ready logic into Surveyor Extract api to own file Split commands into own files Improve names Merge plugin config provider into plugin manager Encapsulate plugins in plugins manager Make plugin.languages readonly Move plugin config provider to plugins file Remove extra tslint file Pick up new tslint version Pick up TS 3.2 rc Update tslint plugin version ensure backward compatibility for Tracker Update md grammar Strict null check decorationsService Strict null check work Debug API: comment cosmetic Debug API: finalize new DebugSession attributes; fixes #51785 Debug API: finalize breakpoint ID; fixes #48722 add peek declaration commands, #62483 Have overwriteEncoding be called Redirect vscode-resource requests remove TPromise from win32 updateService debt: remove TPromise from cli add commitHash to cgmanifest Include extension version #62870 Show all system extensions in dev mode Fix #62870 remove default fields from launch.json Fixes Microsoft/monaco-editor#1191 Fix #62861 fix suggest widget in standalone editor cleanup linux build linux build move off Linux Hosted fix-62365 : _saveState function handled reset state machine when removing a scheme, #62800 use state machine for link detection, #62800 Handle on non-Windows (#63208) Fix #62489 Fix #62370 tweak regex #62800 debug hover has a fixed height: include height of horizontal scroll bar into computation tree horizontoal scrolling: pretend the content has extra 10px instead of pretending the view is 10px shorter Fixes Microsoft/monaco-editor#1013 Use <user-file-path> instead of aaaaaaaaaa (#63075) fix-62365 : Added useGlobalStorageForSuggestions Setting Bump node2 Attempt to fix #63047 Use correct position for requesting closing jsx tags More Promise removal Replace !isFalsyOrEmpty with isNonEmptyArray Introduce isNonEmptyArray Fix refactoring action provider not being queried when using a kind filter Fix possible undefined access exception when using apply "first" for a code action and no code actions are returned Fix #63033 Fix #63088 Don't disable manual code action requests on blank lines Use hasModel type guard Fixing some more restrictive tslint errors Remove extra await Improve method names Make sure we dispose of reader properly Fix #62980 add all cgmanifests. Still no commitHash Revert "Fix #62980" Fix #62980 Make capabilities dynamic custom name when there are multiple outline providers tree: if horizontal scrolling is enabled leave space for it Fix #60014 fix #63126 fixes #61986 only add focus change listener once Debug API: surface Breakpoint.id; for Microsoft/vscode#48722 Fix #62794 Do not pass context explicitly add LocationLink use it in Declaration-type, make DefinitionLink an alias, #62483 tweaks Move uri transformer to shared process node-debug@1.30.1 Fixes Microsoft/monaco-editor#1183 correct fix for #63028 fix #63062 Merge pull request #63096 from eamodio/fixes-markedstring-href-encoding prepare for ts 3.2 Fixes #63095 - html encode hrefs in marked strings Fix #63015 Strict null auto add Fixing TS 3.2 compile errors Use 'references' instead of 'occurrence' to power document highlights Expose 'apply' and 'diff --cached' from git extension API fix #63028 add config to vscode.DebugSession make IConfig.name mandatory debug api: add workspacefolder to DebugSession Fixes #62981 Merge pull request #63027 from Logerfo/master Merge branch 'master' into pr/Logerfo/63027 Tweaks to channel usages Execute extension webpacking in sequence send duration as micro seconds, #60332 debt - less TPromise grow background images with height (#62483) and a better fix for icon twitch Fix editor publishing scripts (on Windows) CompletionItem.insertText is not optional Fixes Microsoft/monaco-editor#1176 Fix some types Fixes Microsoft/monaco-editor#1003 Restore that the editor can run in a browser explorer do not always reaveal in middle, jump less remove commit hash as tryout fix strict null checks in remoteAgentServiceImpl fix strict null checks in downloadIpc add alias type for Declaration, #62483 stop profiling as soon as extension host is responsive again, #60332 Strict null checks for keyboardMapperTestUtils remove logic to show an exthost-unresponsive message to the user, #60332 exploration fail silent when not able to connect, #60332 update ref-view extension #62370 Render source and code less prominent test cgamnifests :lipstick: add connection context to IPC fix warning remove workbench layout perf marks Autodetect ksh scripts as shellscript (#62838) fix command name for toggle centered layout event - forward custom leakage threshold to monitor event - add leakage warning threshold logic and configure for renderer tasks.json should use deprecation message for env. config. and command. (#62787) Bump node2 Don't take user file associations into account for webview mime types debug API: introduce DebugAdapterProvider Don't explicitly add folder name to task labels Switch VS Code workspace to use typescript-tslint-plugin Fix overload Strict null check extensionsAutoProfiler Strict null check state service Strict null check zip Strict null check menusExtensionPoint Strict null check downloadIpc Strict null auto add Merge pull request #59193 from usernamehw/copy_empty Ensure menus with no group specified have proper grouping Auto close <> in js/ts Merge pull request #61993 from iBlackShadow/iblackshadow/fix-search-history-not-being-saved Format searchView.ts tweak telemetry #60332 fix compile issue always enable extension host profiling first cut of auto extension profiler, #60332 update v8 profiler package Merge pull request #61926 from philiparola/master repl: Ignore inactive sessions which got cleared - so they are not shown any more ipc: improve serialization perf, add array support enable custom title/menus on linux (#62866) null checks update monaco.d.ts tweaks Fix tests Explore :lipstick: explore extensions management debt - less TPromise fixes #62606 assign max-height to type-label to prevent icon height changes, #62758 fix #62344 add API command for declaration provider, #62483 add missing monaco.d.ts add proposed api for declaration provider, add test, add ipc logic, #62483 add internal interfaces and actions for go to declaration, #62483 fix #62059 Merge branch 'win32-sign' fixes #62865 add some padding right to code lens, #62842 split view views: do not jump when revealing remove sha1 win32 cert signing fixes #62873 Setting tab details opacity after #61371 Fix missing high-contrast outline in settings editor Fix #59444 Merge pull request #61371 from c5inco/tabs-fix Merge branch 'master' into iblackshadow/fix-search-history-not-being-saved Add an entry to the search history every time a search is done Fixes Microsoft/monaco-editor#1120 Fixes #62835 Merge pull request #62293 from gpoussel/fix-62278 Do not terminate link if `[` occurs in the authority section of URLs (allow for ipv6 authorities) Merge pull request #62667 from YisraelV/deleteCommand Test & tweaks Use overload for #62806 Observe isIncomplete metadata passed by from a plugin Strict null check driver Strict null check inPlaceReplace Strict null checking editor/contrib/format Strict null check storageService Strict null check launch service lines operations strict null check. More native promise adoption More native promise adoption Native promise adoption inPlaceReplace strict null checks. Indentation strict null checks go to error strict null checks. Parameter hint strict null checks. Color Picker null checks. dispose submenu after use (#62848) Fix potential submenu leak #62829 Fix #60453 explore classifying extensions fix #62849 Some tweaks Reset extension enablement on install #53526 Migrate from TPromise Migrate from TPromise Wait some more dispose command-palette after usage, #62829 debug: do not report cancled error message Depended on background tasks should only be run once (#62784) debug: minor polish (remove public keyword for consistency) debug: minor polish add missing return #53526 Migrate from TPromise #53526 Migrate from TPromise in Keybindings Editor #53526 MIgrate from TPromise in log #53526 Migrate from TPromise in localizations #53526 Migrate from TPromise in Output panel #53526 Migrate away from TPromise in Problems panel #53526 Migrate away from TPromise in Localizations land #53526 Migrate away from TPromise in views land more missing monaco.d.ts make debug State a const enum Telemetry for extension activation times debug: make sure to dispose contributed context menu missing monaco.d.ts changes tweak markdown string conversion and rendering working on markdown string dto add Uri.parse(value, strict) so that missing scheme throw Update extHostDebugService.ts Merge pull request #62823 from leonm1/master Try fix timing issues Revert "Make vscode.executeCommand('vscode.previewHtml', ...) a compile error" Fix #62785 empty lines in debug console copyAll Revert strict null checks on config Strict null checks Strict null checks Remove windows-process-tree types if they get installed Fix windows process tree being included twice on windows Support rendering color completions from a ts plugin as colors in the suggest list Strict null checks Update distro. Fix comment update event Strict null checking config Strict null check quick open scorer Fix strict null check Tweaks Fix #62340 - don't try to update text model after it's been disposed Refactoring comment service to not be keyed on handle Authority exploration Fix #62031 Fix NPE from #46353 Make vscode.executeCommand('vscode.previewHtml', ...) a compile error Attempt to fix flaky search tests Fix strict null checks Fix #46353 - add warning that "Use excludes and ignore files" is turned off Fix #36309 - remap \W, \s, and \n in regex to match editor regex search fix linux build Merge pull request #62739 from RDIL/master explorer: fix memento state regression cleanup build folder cleanup snap build build Merge remote-tracking branch 'origin/master' into snap snap updates toward strict null in extHostTypes #61543 fixes #62778 Use ES6 promises snap update service fix #62772 Reconfigure default build and test tasks should update tasks.json (#61857) #61590 add edit json action for keybindings editor Copy settings scope and query when switching from UI to json - Fix #61590 #61590 - show settings editor actions in editor toolbar instead of private ... menu Tweaks Clean up old rg cli props Only set --encoding flag when files.encoding is set. For some reason, --encoding=utf8 is slower when searching large binary files with \n in the query... Replace TPromise in settings #53526 Update distro hash Add alert when trying to use the previewHtml command while developing an extension Auto add strict null checks Allow-list cleidigh and usernamehw (#56883) Enhance LabelService Merge pull request #1 from RDIL/imgbot Tweak IExtHostContext Render more details in running extensions Exploration with authority Minor tweaks Final search TPromise removal #53526 Fix more error handlers behind Promise.join Remove TPromise from search land #53526 #53526 - remove TPromise from SearchService #53526 - remove some TPromise references from search proc Remove no longer necessary 'use strict' Expose force flag for deleting branch on git extension API Better timeout installation Tweaks to transformer Use more URIs Expand comment reply area on focus Add compilation output Minor tweaks fix artifacts debt - less TPromise #53526 :lipstick: tweak snippet use snap cleanbuild build debt - less TPromise #53526 :lipstick: debt - use const enum for MenuId bring back snap build tasks remove build message fix #62526 set exec bit set exec bit fix #62208 remove args from electron launch cleanup snapcraft.yaml reenable builds Convert TPromose -> Promise Convert TPromise -> Promise. simplify code, #62335 fix #62335 mainThreadDebugService: get rid of TPromise fix build contextMenuDelegate: getActions is no longer async 'custom' task type should be '$customized' to conform to API doc (#62710) Update NPM script explorer tree view when package.json changes build 32bit snap viewsViewlet: openView is not async debt - less TPromise instantiation #53526 debt - remove TPromise from action provider interface because it is never async, #53526 debug: To reduce flashing of the path name and the way we fetch stack frame. We need to compute the source name based on the other frames in the stale call stack debug: only append stale call stack if there are more frames to come debt - less TPromise #53526 isolated yarn build yarn debt - more TPromise removal #53526 debt - less TPromise #53526 build snap command snap add notification for linux issue (#62683) snap snap Strict null check paths.ts [ImgBot] Optimize images Sort tsconfig.strictNullChecks.json Strict null check more search files Fix return of openReporter in issueService strict null check replace.ts Strict null check more search files Add textSearchManager to strict null checks strict-null-check ripgrepSearchUtils Fix menuService path in strictNullChecks list get node in build Remove TPromise from issue service, #53526 get snap building debt - Barrier use real promise debt - let menu listen to (new) menu registry change events instead of listing to the extension host being ready. that simplifies this a lot and help with show menu sooner debt - less TPromise comment out component detection faster build build build whitespace tfs snaps mock debug: return type update snapcraft.yaml fix #62112 - merge overlapping delete operations cleanup debugConfigurationProviders properly let's go crazy: use native promise in debug land set executable bits debug: make sure debug stop can stop initializing state add LinuxSnap build step cleanup linux yaml build definition strict null trouble debt - less TPromise construction whitespace Update makefile colorize tests according to the latest grammar. (#61961) Fixes #62655: mainThreadTask should use unique keys for task provider registration add test for #61919 strictNull trouble clone DAP messages properly Handle error (#31450) Show README instead of welcome page, if it exists (#60061) add log messages for all language features (IntelliSense, formatting etc) fixes #43099 fixes #62390 Merge branch 'master' into tyriar/snap Updated grammars Themable Welcome background (fixes #46816) Reload grunt and jake tasks after npm install After npm install gulp extension should find tasks (#62129) debt - remove TPromise from telemetry world Fix #59926 Fixes #62649: Don't serialize URI as JSON in DTOs revert debt - remove now obsolete smoothScrollingWorkaround setting debt - less TPromise in service interface Revert "Add strict null checks in issue and launch services, #60565" Test for multiline selection for wrap Update markdown grammar Add strict null checks in issue and launch services, #60565 Use TS 3.1.4 for building VS Code Update js/ts grammar Use set instead instead of regexp for kind modifiers Enable file icons for js/ts path intellisense Always show the code action light bulb if quick fixes or refactorings are available Version js/ts Api Remove comment user icons that fail to load Use api for onCompletionAccepted instead of command Fix #62446, increase opacity of selection highlight bg Adding command that is fired when a js/ts completion is accepted Strict null checks Fix strict-null-check Fix #62409 - resolve exclude patterns for searchPaths correctly Strict null checks Fix strict null errors in encoding and storage Strict null checks Send only needed extension data to issue reporter, fixes #62481 Clean up unused parameter from PR remove unnecessary filter conversion (#62505) debug issues to weinand debug: add "Run to Cursor" to command palette debt - less TPromise fix #62457 Fix merge compile error Fixes #62594: Resolving process task doesn't take task system into account update git iconv-lite dependency enable component detection in product builds debug repl: Make sure to select the session if debugging is already active Merge pull request #62504 from cleidigh/selectbox-vo-label strict null checks: add dataTree strict null checks: add objectTreeModel strict null checks: add indexTreeModel strict null checks: abstractTree move ITreeModelOptions to /tree strict null checks: several ipc utils strict null checks: issueIpc.ts strict null checks: grid.ts disable bogous test, #62587 debt - less TPromise in mainThread-things debt - less TPromise in tests debt - less TPromise in webview stuff Merge branch 'dbaeumer/56721' Clear doesn't work for extension contributed tasks (#62495) sidebarFocus -> sideBarFocus. Part of #62270 null checks Merge remote-tracking branch 'origin/master' into tyriar/snap Added ability to output extension info to clipboard (#56514) Force InstallCount sort only for empty extension query #62426 SelectBox: ComboBox role workaround for native select Addresses: #60929 Fix #62146, Fix #62149 Extension install error copyediting Fix typo, mismatch whitespaces in comments. Fix typo in comments Fix typo in comments Fix css dependency Update css service for #62159 fix #62460 Merge pull request #62294 from xfix/patch-3 Merge pull request #51197 from JeffreyCA/smooth-caret-animation Merge remote-tracking branch 'origin/master' into pr/JeffreyCA/51197 Merge pull request #50534 from AdrieanKhisbe/grammar-injection-consider-general-types update references-view extension Merge remote-tracking branch 'origin/master' into pr/AdrieanKhisbe/50534 Merge pull request #50312 from irrationalRock/fix-34345 Remove default keybindings Merge remote-tracking branch 'origin/master' into pr/irrationalRock/50312 fix localization smoketest update distro version bump update distro allow references view to use proposed api, add as built in extension commands and widgets do not get along nicely node-debug@1.29.2 remove bad submodule fix #62220 repl: only dispose listener if a new session is selected fix #62412 :lipstick: fixes #61524 debug: workaround out of precaustion end intiialising state when adapter ends Remove trailing comma Update GDPR annotation Re Microsoft/vscode-pull-request-github#652. Reply/Add comment button should be enabled if the comment editor is not empty. Fix Microsoft/vscode-pull-request-github#652. Cache in progress new comment. Skip malicious check when --disable-extensions (#62351…

rebornix assigned sbatten Nov 17, 2018

rebornix self-assigned this Nov 17, 2018

alexdima added the bug Issue identified by VS Code Team member as probable bug label Nov 19, 2018

alexdima added this to the October 2018 milestone Nov 19, 2018

alexdima added the important Issue identified as high-priority label Nov 20, 2018

alexdima assigned joaomoreno Nov 20, 2018

alexdima mentioned this issue Nov 20, 2018

Add a setting like fixedOverflowWidgets for the context menu #1203

Open

joaomoreno closed this as completed in microsoft/vscode@92402b8 Nov 21, 2018

joaomoreno added a commit to microsoft/vscode that referenced this issue Nov 22, 2018

further fixes to microsoft/monaco-editor#1199

b36ee32

joaomoreno added a commit to microsoft/vscode that referenced this issue Nov 22, 2018

fixes microsoft/monaco-editor#1199

9dcfa54

joaomoreno added a commit to microsoft/vscode that referenced this issue Nov 22, 2018

further fixes to microsoft/monaco-editor#1199

582dfa4

vscodebot bot locked and limited conversation to collaborators Oct 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Right click opening command palette window #1199

Right click opening command palette window #1199

yln99517 commented Nov 17, 2018

rebornix commented Nov 17, 2018

alexdima commented Nov 19, 2018

sbatten commented Nov 19, 2018

joaomoreno commented Nov 20, 2018

alexdima commented Nov 20, 2018 •

edited

sbatten commented Nov 21, 2018

joaomoreno commented Nov 21, 2018

Right click opening command palette window #1199

Right click opening command palette window #1199

Comments

yln99517 commented Nov 17, 2018

rebornix commented Nov 17, 2018

alexdima commented Nov 19, 2018

sbatten commented Nov 19, 2018

joaomoreno commented Nov 20, 2018

alexdima commented Nov 20, 2018 • edited

sbatten commented Nov 21, 2018

joaomoreno commented Nov 21, 2018

alexdima commented Nov 20, 2018 •

edited