Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13.2 Chinese input randomly can not input characters #1663

Closed
Brooooooklyn opened this issue Nov 7, 2019 · 5 comments · Fixed by microsoft/vscode#84121
Closed

iOS 13.2 Chinese input randomly can not input characters #1663

Brooooooklyn opened this issue Nov 7, 2019 · 5 comments · Fixed by microsoft/vscode#84121
Assignees
Labels
info-needed Issue requires more information from poster safari-ios

Comments

@Brooooooklyn
Copy link

monaco-editor version: 0.18.1
Browser:
Safari
OS:
iOS 13.2

Steps or JS usage snippet reproducing the issue:
Playground

@Brooooooklyn Brooooooklyn changed the title iOS 13.2 Chinese input Randomly can not input characters iOS 13.2 Chinese input randomly can not input characters Nov 7, 2019
@Brooooooklyn
Copy link
Author

In iOS 13.2, System Chinese input will trigger an additional CompositionEvent with empty data after input some words.

ios-monaco-bug 2019-11-07 18_24_49

@rcjsuen
Copy link
Contributor

rcjsuen commented Nov 7, 2019

@Brooooooklyn The Monaco Editor doesn't support mobile platforms at the moment.

See #246, #1365, #1504, and I'm sure there are many more out there.

@Brooooooklyn
Copy link
Author

iPad OS 13.2 has the same issue, even with physical keyboard. So I think it's worth to fix it.

@rebornix
Copy link
Member

rebornix commented Nov 7, 2019

Thanks I can confirm that Safari on iOS emits double composition end events

Safari on macOS catalina
image

Safari on iOS13 emulator
image

@Brooooooklyn can you provide more details about how to reproduce the issue you described "randomly can not input characters" as I can't reproduce this issue from my side. Once a good reproduce step is provided, we can move this issue to VS Code repo.

@rebornix rebornix added the info-needed Issue requires more information from poster label Nov 7, 2019
@rebornix rebornix self-assigned this Nov 7, 2019
@Brooooooklyn
Copy link
Author

Brooooooklyn commented Nov 8, 2019

The screenshot below is running monaco editor playground on iOS 13.2 emulator
I can't find the step which can stablely input words successfully.
But I found that simply return when compositionend event emmited with empty string could fix this issue: https://github.com/microsoft/vscode/pull/84121/files#diff-b57d2c0cf11cc9d73357705196b8b3cbR276-R278
monaco-ios-bug

Brooooooklyn added a commit to Brooooooklyn/vscode that referenced this issue Nov 12, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster safari-ios
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants