Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when trying to deep clone options with some diff providers #3558

Closed
hediet opened this issue Feb 15, 2023 · 1 comment · Fixed by microsoft/vscode#192151
Closed

Crash when trying to deep clone options with some diff providers #3558

hediet opened this issue Feb 15, 2023 · 1 comment · Fixed by microsoft/vscode#192151
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor verified Verification succeeded
Milestone
September 2023

Comments

@hediet
Copy link
Member

hediet commented Feb 15, 2023

https://microsoft.github.io/monaco-editor/playground.html?source=v0.35.0#XQAAAALJAgAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw2YJxhBJ5fGM3Queb1ah93-Z-fEWlh-VYpSpIB1SIuSnmBtYUL4DnTtsvxett2xneKwS44HeOBuAxAgi517VruuDv_k4eqqZDT1PBxtsNkMc2f4IgtkL4Dh48fnA6_Kxr5XpcERx0cVzeBajJ03aehy3VFPZ7GKv5-PdEnRILg8KJxROI-BBpqu8aRiwExPtr__Q2iMIgQlB3dPg2xdR7xMgufUdiXz69l6kQSi7s9qpa4k3ymzeGlWlLQQwKqlCnSvDKs2a5xRkU8ZHuUgxcatxko4xlGykrjdtrnoHUCmnDvQmXjw12PN6CovC7cPxxMxSkbsB8LrxNISleBB6UJzK6joWdJYtb3QUKTHHIYx3KyJscO_vIJ5ts_Vlat5Klz23WV7X_3Ghlsg
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor labels Feb 15, 2023
@hediet hediet self-assigned this Feb 15, 2023
@hediet hediet mentioned this issue Jun 21, 2023
Closed
@hediet hediet mentioned this issue Sep 4, 2023
Merged
@hediet hediet added this to the September 2023 milestone Sep 4, 2023
hediet added a commit to microsoft/vscode that referenced this issue Sep 4, 2023
@hediet
Removes support to pass in diff algorithm via option in favor of a se…
c036c21 
…rvice.

Fixes microsoft/monaco-editor#3558
@hediet
Copy link
Member Author

hediet commented Sep 4, 2023 •
edited

Passing in the diff algorithm as option is no longer supported. Instead, a service should be used.
Playground example (check playground example source code)

hediet added a commit to microsoft/vscode that referenced this issue Sep 4, 2023
@hediet
Removes support to pass in diff algorithm via option in favor of a se…
65e921c 
…rvice.

Fixes microsoft/monaco-editor#3558
@bhavyaus bhavyaus added the verified Verification succeeded label Sep 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

Removes support to pass in diff algorithm via option in favor of a service. microsoft/vscode
2 participants
@hediet @bhavyaus