Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update import path for browser-esm-webpack-small #3402

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Update import path for browser-esm-webpack-small #3402

merged 1 commit into from
Jan 31, 2023

Conversation

JoyceZhu
Copy link
Contributor

@JoyceZhu JoyceZhu commented Nov 9, 2022

The npm run build step for the browser-esm-webpack-small example is currently failing due to an outdated import path referencing findController in its index.js.

I've fixed the build by updating the import path to findController's current location.

@hediet hediet enabled auto-merge January 31, 2023 11:46
@hediet hediet added this to the January 2023 milestone Jan 31, 2023
@hediet hediet merged commit af396f2 into microsoft:main Jan 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hediet hediet hediet approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoyceZhu @hediet @chrmarti