Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up the ARM32 TA fTPM implementation with master. #52

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

javieralso-arm
Copy link
Contributor

Catch up the current Arm32 TA fTPM implementation with master.

The Arm32 fTPM sample TA included in this repository has been used as test and PoC to illustrate the interaction between TF-A Measured Boot functionality 1 and a TPM service.

We would like to upstream all the changes to enable Measured Boot functionality on that sample application, starting with a patch
to catch up the TA with Master, as it seemed to be out of date.

Signed-off-by: Javier Almansa Sobrino javier.almansasobrino@arm.com

@ghost
Copy link

ghost commented Feb 18, 2021

CLA assistant check
All CLA requirements met.

@amarochk amarochk self-requested a review February 21, 2021 20:24
Copy link
Contributor

@amarochk amarochk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current (post-1.38 revisions) of the TPM reference implementation stopped using "Implementation.h" header having replaced it with "TpmProfile.h" and "TpmAlgorithmDefines.h". It still remains in the source tree for the historical reference purposes, but is not used or maintained. So I suggest to remove it from your your code to avoid possible side-effects.

@javieralso-arm
Copy link
Contributor Author

The current (post-1.38 revisions) of the TPM reference implementation stopped using "Implementation.h" header having replaced it with "TpmProfile.h" and "TpmAlgorithmDefines.h". It still remains in the source tree for the historical reference purposes, but is not used or maintained. So I suggest to remove it from your your code to avoid possible side-effects.

Thanks for the comment @amarochk . I will address it ASAP.

Regards

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
@javieralso-arm
Copy link
Contributor Author

Hi @amarochk

I removed Implementation.h from the port as per your suggestions.

Let me know if there is anything else needed.

Cheers,
Javier

Copy link
Contributor

@amarochk amarochk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@amarochk amarochk merged commit 1b35000 into microsoft:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants