-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows DLL available to download #1507
Comments
Did you already try to compile this for PHP 8.4.0 VS17, Alpha 2? |
Hi @Jan-E , Yes, I have tried to compile the latest version (5.12.0). The result is poor. Error example: I will work on it later. |
@cmb69 Jean-Baptiste Nahan aka @macintoshplus was able to compile php_pdo_sqlsrv.dll for PHP 8.3, but this fails for PHP 8.4.0 Alpha 2. Any idea what could be causing that? |
@Jan-E, no particular idea, but since the latest commit in this repo was about updating the changelog to state "Support for PHP 8.3", I'd assume that the maintainers had no time yet to establish compatibility with PHP 8.4. |
Also note that https://github.com/php/php-windows-builder already supports building pdo_sqlsrv and sqlsrv (and respective DLL downloads are available via the PECL website). I assume that mass rebuilds will be done later. |
@Jan-E what architecture (x86/x64) and ts/nts do you need? |
That apparently is not supported with |
Ok, but To solve this error Why? Other error |
I had roughly the same errors. For GRPC 1.63.0 I had to go for standard C11:
Might be a try. Change the CFLAGS into the good one for SQLSRV or PDO_SQLSRV |
No, this is not (and should not be) needed. See php/php-src#15094 regarding the php_random.h issue, and php/php-src#15096 regarding an issue with zend_portability.h. I did successfully build (haven't run any test, though), but need to sort out the mess I've created in the meantime. Perhaps there are more issues that need to be properly fixed. And of course, the
That should be irrelevant, since this is a C++ extension. The default (C++14) should be good enough (with the already existing |
Apparently not. :) |
Actually, all of them. This is what triggered my question: |
@cmb69 I have build sucessfully with your change in PR and this change: file:
|
I think that this patch would change the behavior: Better use #1496 instead, in my opinion. |
Even with the patch from php/php-src#15100 I am still getting That seems to be due yo the fact that it is used in L469 of msphpsql/source/shared/core_sqlsrv.h Lines 467 to 472 in 41ac126
What did you change to make it compile? |
Try with an older C++ standard; that failed for me with C++20, but worked with the default (for me C++14). |
Works. https://phpdev.toolsforresearch.com/php-8.4.0alpha2-nts-Win32-vs17-x64.htm |
Note that building against early pre-releases is certainly a good idea to catch issues (either necessary changes to extension code, or, like in this case, upstream issues), but please do not redistribute such builds (at least add a warning), since the API version bump usually is done shortly prior to RC1, so previously build extension cannot be loaded anymore ("expected API version X, but got Y"). And building during RC stage for redistribution might still not be the best idea. When the PECL build machine was still running, we usually triggered mass rebuilds only a while after GA. |
The topic on Apachelounge starts with:
|
It seems pdo_sqlsrv 5.12.0 builds fine against PHP 8.4.0alpha2 with the same modifications. |
Yes, both sqlsrv 5.12.0 extensions are already included: |
Hi, Like last night, the build error is always the same. I have tried using What have you changed after the 2 patches of @cmb69 and removing
@cmb69 your 2 patches work fine and resolve errors but not all. |
Ok, I can build the extensions. To solve the error, I removed the extension source code and extracted it again. |
Warnings, no errors. Sorry for the long lines. I am working on an iPad right now with a VNC connection to my build machine.
|
Now, I have this log too. |
In a perfect world, these warnings should be resolved, but as far as I can tell, these are level 2 and 3 warnings; if you want them suppressed, remove the |
With a x86 build there are less warnings.
|
With a reply:
|
I am pleased to announce that this extension is now compiled for Windows by the PHP Extension Repository site.
You can download the DLLs on the extension page: https://phpext.phptools.online/extension/database/pdo_sqlsrv-96
If you have any questions, I am available to discuss them.
The text was updated successfully, but these errors were encountered: