Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for data type sql_variant #146

Closed
wants to merge 1 commit into from
Closed

Add support for data type sql_variant #146

wants to merge 1 commit into from

Conversation

xalopp
Copy link

@xalopp xalopp commented Sep 6, 2016

Fixes #127

@meet-bhagdev
Copy link
Contributor

@xalopp Thanks for the PR. We will look into this in the next few weeks.

@photodude
Copy link

@xalopp can you fix the merge conflicts here so we can try to get a PR review?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.071% when pulling 3182692 on xalopp:issue_127 into fe797fa on Microsoft:PHP-7.0-Linux.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.071% when pulling 674b237 on xalopp:issue_127 into fe797fa on Microsoft:PHP-7.0-Linux.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.071% when pulling 6140f44 on xalopp:issue_127 into fe797fa on Microsoft:PHP-7.0-Linux.

@xalopp
Copy link
Author

xalopp commented Feb 12, 2017

@photodude sure. I added the test case which it's failling, but I'll still need to figure out, how to get my fix running again.

@Hadis-Knj Hadis-Knj moved this from Backlog to In Progress in msphpsql May 17, 2017
@Hadis-Knj Hadis-Knj moved this from In Progress to Need Review in msphpsql May 17, 2017
@Hadis-Knj
Copy link

@xalopp thanks for your contribution, closing this PR as it doesn't cover all cases that we need to add sql variant. #399 is the list of changes in order to support this feature. note that this feature is included in 4.2.0 release

@Hadis-Knj Hadis-Knj closed this May 24, 2017
@Hadis-Knj Hadis-Knj moved this from Need Review to Completed in msphpsql May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
msphpsql
Completed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants