Readme and Changelog update #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitam
reviewed
Feb 2, 2017
CHANGELOG.md
Outdated
| ## Windows/Linux 4.1.6 - 2017-02-03 | ||
| Updated PECL release packages. Here is the list of updates: | ||
| ### Added | ||
| - Merge Linux and Windows code. |
There was a problem hiding this comment.
Use past tense for 'Merge' to be consistent with the rest. Also, we won't be renaming the branch to DEV, will we?
There was a problem hiding this comment.
One more thing, are we going to modify the version number in shared/version.h as well?
yitam
reviewed
Feb 2, 2017
| - Fixed PECL installation errors when PHP was installed from source ([issue #213](https://github.com/Microsoft/msphpsql/issues/213)). | ||
| - Fixed segmentation fault with PDOStatement::getColumnMeta() when the supplied column index is out of range ([issue #224](https://github.com/Microsoft/msphpsql/issues/224)). | ||
| - Fixed the assertion error (Linux) when fetching data from a binary column using the binary encoding ([issue #226](https://github.com/Microsoft/msphpsql/issues/226)). | ||
|
|
There was a problem hiding this comment.
Do I also need to add the issue numbers in PECL packages?
yitam
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.