Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH308 #310

Merged
merged 7 commits into from
Mar 1, 2017
Merged

GH308 #310

merged 7 commits into from
Mar 1, 2017

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Feb 28, 2017

Do not set empty string to null (issue #308)

@yitam yitam changed the title Gh308 GH308 Feb 28, 2017
Hadis-Knj
Hadis-Knj reviewed Mar 1, 2017
View reviewed changes
Copy link

@Hadis-Knj Hadis-Knj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for sqlsrv (changes are in core_layer) and null cases

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 52.642% when pulling 8d2d637 on yitam:GH308 into f0a5da9 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 52.642% when pulling 8d2d637 on yitam:GH308 into f0a5da9 on Microsoft:dev.

@yukiwongky yukiwongky merged commit f73c23b into microsoft:dev Mar 1, 2017
@yitam yitam deleted the GH308 branch March 1, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hadis-Knj Hadis-Knj Hadis-Knj left review comments

@yukiwongky yukiwongky Awaiting requested review from yukiwongky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yitam @coveralls @Hadis-Knj @yukiwongky