Allow client and server to share bindings #2299
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Jan 16, 2022
| // | ||
| // Indicates whether this binding has client side owners or not. | ||
| // | ||
| BOOLEAN ClientOwned : 1; |
There was a problem hiding this comment.
Let's rename this "Owned" flags to something like "Used` instead.
|
I think my openssl submodule is on an old commit and it's showing up in this PR. I'll fix that before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow bindings to be shared between clients and servers. This will allow a client to create outbound connections on the same address and port as a listener on the same node.