Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Parameter for TLS Provider #2762

Merged
merged 1 commit into from
May 27, 2022
Merged

Expose Parameter for TLS Provider #2762

merged 1 commit into from
May 27, 2022

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented May 27, 2022

Description

Fixes #2761. Adds a new parameter that can be called via GetParam to query the compiled in TLS provider. This allows application code to handle any TLS provider specific differences.

cc @rzikm

Testing

Added get/set test.

Documentation

Updated for new parameter.

@nibanks nibanks requested a review from a team as a code owner May 27, 2022 12:48
@nibanks nibanks enabled auto-merge (squash) May 27, 2022 12:49
@nibanks nibanks merged commit 3c8faf6 into main May 27, 2022
@nibanks nibanks deleted the nibanks/tls-provider branch May 27, 2022 16:38
@GF-Huang
Copy link

GF-Huang commented Feb 3, 2023

Is this means .NET 7 QUIC classes can work on older Win10 even if Win7? For the QUIC namespaces docs, I can't see any description about this.

@rzikm
Copy link
Member

rzikm commented Feb 6, 2023

Is this means .NET 7 QUIC classes can work on older Win10 even if Win7? For the QUIC namespaces docs, I can't see any description about this.

We don't have test coverage for running with OpenSSL-based MsQuic on Windows, but last time I tried it it worked (after integrating the change from this PR). It is not officially supported, but we are considering official support in 8.0. If you find any issues, feel free to raise a PR in dotnet/runtime repo.

The only pitfall of OpenSSL on Windows I can remember now is that any certificates you use must be exportable, because we need to serialize them to memory in order to pass them to MsQuic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow applications to query which TLS backend MsQuic uses.
4 participants