Support for changing alpn on listener callback (#2418) #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
Co-authored-by: Nick Banks <nibanks@microsoft.com>
nibanks
reviewed
Aug 9, 2022
Co-authored-by: Nick Banks <nibanks@microsoft.com>
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
|
/azp run ci |
…hub.com/liveans/msquic into liveans/support-callback-neg-alpns-2418
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nibanks
reviewed
Aug 9, 2022
nibanks
reviewed
Aug 9, 2022
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nibanks
approved these changes
Aug 10, 2022
ManickaP
reviewed
Aug 10, 2022
There was a problem hiding this comment.
I don't fully understand the changes here, but we don't need any API changes. What we need is to be able to narrow down ALPN list when we call ConnectionSetConfiguration after we got NEW_CONNECTION. Note that this needs to be asynchronous since we're invoking user provided async callback, so we cannot set it within NEW_CONNECTION event.
The configuration already supports setting ALPN, we just need msquic to handle it for inbound connections.
| @@ -1820,6 +1820,9 @@ internal unsafe partial struct _NEW_CONNECTION_e__Struct | |||
|
|
|||
| [NativeTypeName("HQUIC")] | |||
| internal QUIC_HANDLE* Connection; | |||
|
|
|||
| [NativeTypeName("const uint8_t *")] | |||
| internal byte* NewNegotiatedAlpn; | |||
There was a problem hiding this comment.
What's this good for? And shouldn't it also have length specified somewhere?
|
I'll make a new PR for this to correct the behavior @ManickaP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2418. This pr aims to support changing alpns on ListenerCallback via the
NewNegotiatedAlpnfield.Testing
Alpn.ChangeAlpn test case already added, also extended that test case to check out of bounds and invalid address.
Documentation
Yes, example usage can be found under
QUIC_LISTENER_EVENT.md