App Controlled Execution Config #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
OS: Windows (User)
OS: Ubuntu
OS: macOS
Area: API
Area: Core
nibanks
commented
Aug 30, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else {*/ | ||
| CxPlatWorkerCount = CxPlatProcMaxCount(); | ||
| ProcessorList = NULL; | ||
| //} |
Check notice
Code scanning / CodeQL
Commented-out code
Comment on lines
+114
to
+117
| /*if (Config && Config->ProcessorCount) { | ||
| CxPlatWorkerCount = Config->ProcessorCount; | ||
| ProcessorList = Config->ProcessorList; | ||
| } else {*/ |
Check notice
Code scanning / CodeQL
Commented-out code
csujedihy
reviewed
Aug 31, 2022
csujedihy
reviewed
Aug 31, 2022
nibanks
commented
Sep 28, 2022
nibanks
commented
Sep 28, 2022
nibanks
commented
Sep 30, 2022
maolson-msft
approved these changes
Sep 30, 2022
ami-GS
reviewed
Sep 30, 2022
| "CxPlatThreadCreate"); | ||
| goto Error; | ||
| #ifndef _KERNEL_MODE // Not supported on kernel mode | ||
| if (ExecProfile != QUIC_EXECUTION_PROFILE_TYPE_MAX_THROUGHPUT) { |
There was a problem hiding this comment.
Does max throughput related flag works without splitpartitioning?
There was a problem hiding this comment.
Yes. Max throughput just means separate threads for UDP and QUIC now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the MsQuic API to allow for the application to explicitly configure the execution of MsQuic internals. This is the next step to allow the app to fully control execution.
Testing
Existing CI
Documentation
to-do