Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf Counter Snapshot Improvements #3167

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Perf Counter Snapshot Improvements #3167

merged 2 commits into from
Oct 19, 2022

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Oct 18, 2022

Description

Two main updates to perf counter snapshots:

  • Change interval from 30 seconds to 1 second
  • Fire off the ETW event every time we snapshot

The goal here is that if we collect low volume logs, we implicitly will collect our perf counters.

TODO: Update WPA plugin to decode these counters for nice viewing.

Testing

Perf pipeline to make sure there is no significant regression.

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner October 18, 2022 13:28
@nibanks nibanks merged commit 7719b64 into main Oct 19, 2022
@nibanks nibanks deleted the nibanks/snapshot-perfcounters branch October 19, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtfriesen mtfriesen mtfriesen approved these changes

Assignees
No one assigned
Labels
Area: Logging Area: Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nibanks @mtfriesen