Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inline StreamSends #3284

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Support Inline StreamSends #3284

merged 3 commits into from
Dec 14, 2022

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Dec 13, 2022

Description

Adds support for StreamSend calls that already happen on a callback to immediately flush inline, eliminating extra queuing delays (and sometimes eve additional packets sent on the wire).

One tricky piece here is the possibilities of additional callbacks as a result. For now, I've disabled when using send buffering because that very likely will complete the send immediately if it can be buffered.

Testing

CI/CD

Documentation

N/A

@nibanks
Copy link
Member Author

nibanks commented Dec 14, 2022

This seems to be crashing the release build, kernel mode tests somehow. I think they somehow generate re-entrant callbacks, and are hitting our asserts. I'm going to turn this back to draft for now, and see if I can fix the latency issue with ACK tolerance.

@nibanks nibanks marked this pull request as draft December 14, 2022 14:48
@nibanks nibanks marked this pull request as ready for review December 14, 2022 19:18
@nibanks nibanks merged commit b5864df into main Dec 14, 2022
@nibanks nibanks deleted the nibanks/stream-send-inline branch December 14, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants