Block Wildcard Address Client Connections

[nibanks]

Description

MsQuic was allowing a client to "connect" to 0.0.0.0 which the stack actually just treats as a wildcard (unconnected) socket.

Testing

Existing CI

Documentation

We don't currently document whether this was allowed or disallowed. Maybe we should be explicit there?

[jdcole]

For the history book, this issue was discovered running quicsample -client -unsecure -target:0. Thanks for the fix @nibanks!

[ami-GS]

required test is failing?

[03/08/2023 12:32:33] Process had nonzero exit code: 1
##vso[task.LogIssue type=error;][03/08/2023 12:32:33] ParameterValidation.ValidateConnectionParam failed:
Note: Google Test filter = ParameterValidation.ValidateConnectionParam
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
Initializing for User Mode tests
[----------] 1 test from ParameterValidation
[ RUN      ] ParameterValidation.ValidateConnectionParam
/__w/1/s/src/test/lib/ApiTest.cpp:3373: Failure
Connection.SetParam( QUIC_PARAM_CONN_REMOTE_ADDRESS, sizeof(Dummy), &Dummy) failed, 0x[16](https://github.com/microsoft/msquic/actions/runs/4364285556/jobs/7631421949#step:8:17)
[  FAILED  ] ParameterValidation.ValidateConnectionParam ([20](https://github.com/microsoft/msquic/actions/runs/4364285556/jobs/7631421949#step:8:21)5 ms)
[----------] 1 test from ParameterValidation (205 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (366 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ParameterValidation.ValidateConnectionParam

 1 FAILED TEST

[nibanks]

required test is failing?

[03/08/2023 12:32:33] Process had nonzero exit code: 1
##vso[task.LogIssue type=error;][03/08/2023 12:32:33] ParameterValidation.ValidateConnectionParam failed:
Note: Google Test filter = ParameterValidation.ValidateConnectionParam
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
Initializing for User Mode tests
[----------] 1 test from ParameterValidation
[ RUN      ] ParameterValidation.ValidateConnectionParam
/__w/1/s/src/test/lib/ApiTest.cpp:3373: Failure
Connection.SetParam( QUIC_PARAM_CONN_REMOTE_ADDRESS, sizeof(Dummy), &Dummy) failed, 0x[16](https://github.com/microsoft/msquic/actions/runs/4364285556/jobs/7631421949#step:8:17)
[  FAILED  ] ParameterValidation.ValidateConnectionParam ([20](https://github.com/microsoft/msquic/actions/runs/4364285556/jobs/7631421949#step:8:21)5 ms)
[----------] 1 test from ParameterValidation (205 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (366 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ParameterValidation.ValidateConnectionParam

 1 FAILED TEST

Is fixed (down-level) by #3487. We will need to take that first and make a new release to fix the test.