Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Replace NEW_STREAM with PEER_STREAM_STARTED #3586

Merged
merged 1 commit into from
Apr 26, 2023
Merged

docs: Replace NEW_STREAM with PEER_STREAM_STARTED #3586

merged 1 commit into from
Apr 26, 2023

Conversation

PeteAudinate
Copy link
Contributor

Description

There is no QUIC_CONNECTION_EVENT_NEW_STREAM event. Should this be QUIC_CONNECTION_EVENT_PEER_STREAM_STARTED instead?

If not, it would be good to see an example of how to do this.

Testing

N/A

Documentation

Updated

@PeteAudinate PeteAudinate requested a review from a team as a code owner April 26, 2023 13:00
nibanks
nibanks approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix.

@nibanks nibanks added Area: Documentation external Proposed by non-MSFT labels Apr 26, 2023
@nibanks nibanks enabled auto-merge (squash) April 26, 2023 13:12
@nibanks nibanks merged commit 77af914 into microsoft:main Apr 26, 2023
219 checks passed
@PeteAudinate PeteAudinate deleted the peer_event_name branch September 20, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibanks nibanks nibanks approved these changes

Assignees
No one assigned
Labels
Area: Documentation external Proposed by non-MSFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeteAudinate @nibanks