Prevent Path Removal Underflow #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csujedihy
approved these changes
May 12, 2023
csujedihy
reviewed
May 12, 2023
| @@ -53,8 +54,15 @@ QuicPathRemove( | |||
| _In_ uint8_t Index | |||
| ) | |||
| { | |||
| CXPLAT_DBG_ASSERT(Index < Connection->PathsCount); | |||
| CXPLAT_DBG_ASSERT(Connection->PathsCount > 0); | |||
| CXPLAT_DBG_ASSERT(Connection->PathsCount <= QUIC_MAX_PATH_COUNT); | |||
There was a problem hiding this comment.
why don't we make this a teleassert too?
There was a problem hiding this comment.
We could but I really don't expect this assert to be invalid. I am not so sure about the next one, that's why I've made it a tel assert.
nibanks
added a commit
that referenced
this pull request
May 19, 2023
nibanks
added a commit
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add check for invalid path removal case. It shouldn't ever happen, but from some crashes I've seen, I suspect it might be happening.
Testing
Existing automation
Documentation
N/A