Plumb QEO to XDP #3632
Merged
Plumb QEO to XDP #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ami-GS
reviewed
May 16, 2023
Comment on lines
+1339
to
+1344
| // | ||
| // The following logic just tries all interfaces and if it's able to offload | ||
| // to any of them, it considers it a success. Long term though, this should | ||
| // only offload to the interface that the socket is bound to. | ||
| // | ||
|
|
There was a problem hiding this comment.
If we allow enabling some of interfaces, we need to know which interfaces are offloading? to disable the offloading ones later
There was a problem hiding this comment.
hmm, but not sure the operation is _ADD or _REMOVE...
Code could be really complex then
There was a problem hiding this comment.
Right now, the goal isn't to make this perfect, but to just unblock experimentation. So I think this is good enough right now. What do you think?
There was a problem hiding this comment.
yeah, offloading functionality point of view, it should be OK for now
ami-GS
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wire up the initial plumbing to QEO in XDP.
Testing
Must wait for real HW or official tests.
Documentation
N/A