Fix RPS Processor Usage #3702
Merged
Fix RPS Processor Usage #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
previously approved these changes
Jun 14, 2023
|
Can we make the PR description clearer? I think I understand now why it fails. It seems that the proc info array contains items for non-active processes now and RPS client still assumes it only has items for active procs. |
csujedihy
previously approved these changes
Jun 14, 2023
csujedihy
approved these changes
Jun 14, 2023
csujedihy
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent changes to how the processor index is calculated broke RPS tests on Windows. This fixes them by taking into account that a given processor index may refer to an inactive processor (since we track maximum, not active, processors). The RPS test code wants to only use active processors, so it iterates over all processors, skipping inactive ones.
Testing
Automation
Documentation
N/A