-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport packaging and Github workflow migration changes to 2.2 #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a git permission issue that's currently worked around in the github workflows. - Add clang. - Move dockers out of .azure folder.
The previous attempt still failed the build. `git config --global safe.directory '*'` worked in another PR as an individual step in a job. So, try this instead.
- Refactor the build workflow into a resusable workflow. Other workflows that need build artifacts can just call the build workflow. The reusable build workflow is essentially a function that takes various build parameters. This enables us to build and test binaries in different environments and improve how we build stuff in one place. - Merge stress and BVT into the same workflow so we build once for everything.
Use 1ES pool for windows prerelease tests
RUNPATH is by default set to the folder where the binary is located at build time. This makes locally reproducing issues cumbersome for Linux. Also, if the build and test runner machine have different folder structure, our tests won't run due to this issue.
… of the ones in the installed package (#3744) The test is supposed to test if the installed package can be loaded into BVT test. However, the libs are also present in the same folder where the test is. Delete them to make sure libs in the package gets loaded.
csujedihy
added
Area: Build
Area: Testing
Related to test coverage
Area: Automation
Backport
Area: Packaging
labels
Jul 8, 2023
nibanks
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport packaging and Github workflow migration changes to 2.2.
Testing
CI