Minor Changes to Improve Listener Code Coverage #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
commented
Jul 14, 2023
| if (QUIC_FAILED(Status)) { | ||
|
|
||
| if (Listener != NULL) { | ||
| CXPLAT_FREE(Listener, QUIC_POOL_LISTENER); | ||
| } | ||
| } | ||
| CXPLAT_DBG_ASSERT(QUIC_SUCCEEDED(Status) || Listener == NULL); |
There was a problem hiding this comment.
I was able to remove this check entirely because we can never fail after allocating the Listener. But I put an assert here just in case someone changes that in the future.
Codecov Report
@@ Coverage Diff @@
## main #3757 +/- ##
=======================================
Coverage ? 75.58%
=======================================
Files ? 56
Lines ? 15530
Branches ? 0
=======================================
Hits ? 11738
Misses ? 3792
Partials ? 0 |
csujedihy
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that a few lines were uncovered in code coverage, so I did some minimal refactoring to clean that up.
Testing
Existing CI
Documentation
N/A