Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Resolved GCC compilation warning by renaming variable. #3766

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

sadjad
Copy link
Contributor

@sadjad sadjad commented Jul 20, 2023

Description

Renamed the variable 'X509' to 'x509' to fix a compilation warning issued by GCC. The warning was due to the variable name being the same as the class name. This change prevents any confusion or issues related to naming conflicts.

Testing

Do any existing tests cover this change?

Yes.

Are new tests needed?

No.

Documentation

Is there any documentation impact for this change?

No.

@sadjad sadjad requested a review from a team as a code owner July 20, 2023 17:01
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #3766 (d2fbd28) into main (d8a003f) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3766      +/-   ##
==========================================
- Coverage   75.72%   75.56%   -0.16%     
==========================================
  Files          56       56              
  Lines       15554    15554              
==========================================
- Hits        11778    11754      -24     
- Misses       3776     3800      +24     

see 13 files with indirect coverage changes

@nibanks nibanks merged commit 1388329 into microsoft:main Jul 20, 2023
407 of 408 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants