Improve C++ wrapper. #3769
Merged
Improve C++ wrapper. #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3769 +/- ##
==========================================
- Coverage 75.59% 75.57% -0.02%
==========================================
Files 56 56
Lines 15554 15554
==========================================
- Hits 11758 11755 -3
- Misses 3796 3799 +3 |
nibanks
reviewed
Jul 21, 2023
src/inc/msquic.hpp
Outdated
Comment on lines
789
to
798
| static | ||
| QUIC_STATUS | ||
| QUIC_API | ||
| NoOpCallback( | ||
| _In_ MsQuicListener* /* Listener */, | ||
| _In_opt_ void* /* Context */, | ||
| _Inout_ QUIC_LISTENER_EVENT* /* Event */ | ||
| ) noexcept { | ||
| return QUIC_STATUS_SUCCESS; | ||
| } |
There was a problem hiding this comment.
Fix formatting and we need to return an error by default, otherwise it would just accept a connection and leak it.
Suggested change
| static | |
| QUIC_STATUS | |
| QUIC_API | |
| NoOpCallback( | |
| _In_ MsQuicListener* /* Listener */, | |
| _In_opt_ void* /* Context */, | |
| _Inout_ QUIC_LISTENER_EVENT* /* Event */ | |
| ) noexcept { | |
| return QUIC_STATUS_SUCCESS; | |
| } | |
| static | |
| QUIC_STATUS | |
| QUIC_API | |
| NoOpCallback( | |
| _In_ MsQuicListener* /* Listener */, | |
| _In_opt_ void* /* Context */, | |
| _Inout_ QUIC_LISTENER_EVENT* /* Event */ | |
| ) noexcept { | |
| return QUIC_STATUS_NOT_SUPPORTED; | |
| } |
There was a problem hiding this comment.
In fact, I'm not sure it ever makes sense to have a no-op callback for a listener. Maybe we just remove it and always require a callback.
There was a problem hiding this comment.
Makes sense. I will remove this an also update the default parameters in the MsQuicListener c'tor.
nibanks
reviewed
Jul 21, 2023
src/inc/msquic.hpp
Outdated
| }; | ||
|
|
||
| typedef QUIC_STATUS MsQuicListenerCallback( | ||
| _In_ struct MsQuicListener* listener, |
There was a problem hiding this comment.
Suggested change
| _In_ struct MsQuicListener* listener, | |
| _In_ struct MsQuicListener* Listener, |
nibanks
reviewed
Jul 21, 2023
src/perf/lib/PerfServer.cpp
Outdated
| @@ -129,7 +129,7 @@ PerfServer::GetExtraData( | |||
|
|
|||
| QUIC_STATUS | |||
| PerfServer::ListenerCallback( | |||
| _In_ HQUIC /*ListenerHandle*/, | |||
| _In_ MsQuicListener* /*ListenerHandle*/, | |||
There was a problem hiding this comment.
Suggested change
| _In_ MsQuicListener* /*ListenerHandle*/, | |
| _In_ MsQuicListener* /*Listener*/, |
nibanks
reviewed
Jul 21, 2023
src/perf/lib/PerfServer.h
Outdated
| @@ -90,14 +90,14 @@ class PerfServer : public PerfBase { | |||
|
|
|||
| QUIC_STATUS | |||
| ListenerCallback( | |||
| _In_ HQUIC ListenerHandle, | |||
| _In_ MsQuicListener* ListenerHandle, | |||
There was a problem hiding this comment.
Let's update ListenerHandle to Listener here and the others below.
nibanks
reviewed
Jul 21, 2023
src/test/lib/ApiTest.cpp
Outdated
Comment on lines
343
to
347
| QUIC_API | ||
| DummyListenerCallback( | ||
| T, | ||
| void* Context, | ||
| QUIC_LISTENER_EVENT* Event |
There was a problem hiding this comment.
Suggested change
| QUIC_API | |
| DummyListenerCallback( | |
| T, | |
| void* Context, | |
| QUIC_LISTENER_EVENT* Event | |
| QUIC_API | |
| DummyListenerCallback( | |
| T, | |
| void* Context, | |
| QUIC_LISTENER_EVENT* Event |
nibanks
reviewed
Jul 21, 2023
nibanks
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the MsQuicListener implementation in that it adds a proper C++-style MsQuicListenerCallback type. This type is in line with other callback implementations in the C++ wrapper. Furthermore, the PR improves the consistency of some function signatures and adds a few retrieval functions for certain object parameters.
Testing
These changes are affect certain tests, which have been updated accordingly. New API additions where not added to the tests.
Documentation
Smaller API changes and additions have been made and might require doc updates.