Update XDP Usage to v1.0 #3796
Update XDP Usage to v1.0 #3796
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3796 +/- ##
==========================================
- Coverage 77.54% 77.04% -0.51%
==========================================
Files 56 56
Lines 15553 15632 +79
==========================================
- Hits 12060 12043 -17
- Misses 3493 3589 +96 |
| @@ -145,7 +145,7 @@ $NugetSourceFolder = Join-Path $RootDir "src/distribution" | |||
| if ($UWP) { | |||
| $PackageName = "Microsoft.Native.Quic.MsQuic.UWP.$Tls" | |||
| } elseif ($XDP) { | |||
| Copy-Item -Path (Join-Path $PSScriptRoot xdp-devkit.json) -Destination (Join-Path $PackagingDir xdp-devkit-temp.json) | |||
| Copy-Item -Path (Join-Path $PSScriptRoot xdp.json) -Destination (Join-Path $PackagingDir xdp-temp.json) | |||
There was a problem hiding this comment.
Why we would still call it -temp.json?
There was a problem hiding this comment.
Why was it called temp to begin with?
There was a problem hiding this comment.
I remember because you said this file was temporary until we have an official XDP release so we can remove it in the future or something.
There was a problem hiding this comment.
Why do we still need this file with XDP 1.0? I assume now that XDP is official, XDP will guarantee backcompat and we will never need to know which XDP version MsQuic is built on?
There was a problem hiding this comment.
That's a fair question. I think more formalized dependency/package managers tend to check in the precise version they were built against (lock files) even if the logical dependency is less strict, to ensure repeatable builds. Otherwise yes I agree, QUIC should be able to depend on 1.x.
Description
Updates MsQuic to consume the new v1.0 release of XDP for Windows.
Testing
Automated tests.
Documentation
N/A