Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Send Logic to 64-bit Time #3848

Merged
merged 12 commits into from
Sep 11, 2023
Merged

Migrate Send Logic to 64-bit Time #3848

merged 12 commits into from
Sep 11, 2023

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Sep 11, 2023

Description

Updates the send logic to use 64-bit time instead of 32-bit. Makes calculating one-way delay time easier. Also required for larger RTT (i.e. space) scenarios.

Testing

Existing automation

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner September 11, 2023 15:02
@nibanks nibanks added the Area: Core Related to the shared, core protocol logic label Sep 11, 2023
@nibanks nibanks changed the title Nibanks/64-bit-send-time Migrate Send Logic to 64-bit Time Sep 11, 2023
mtfriesen
mtfriesen previously approved these changes Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #3848 (c3244cf) into main (e6d5044) will decrease coverage by 0.34%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main    #3848      +/-   ##
==========================================
- Coverage   86.74%   86.41%   -0.34%     
==========================================
  Files          56       56              
  Lines       16596    16597       +1     
==========================================
- Hits        14397    14343      -54     
- Misses       2199     2254      +55     
Files Changed Coverage Δ
src/core/congestion_control.h 79.59% <ø> (ø)
src/core/connection.h 98.89% <ø> (+1.65%) ⬆️
src/core/path.h 100.00% <ø> (ø)
src/core/sent_packet_metadata.h 100.00% <ø> (ø)
src/core/stream.h 93.33% <ø> (ø)
src/core/cubic.c 77.35% <50.00%> (+1.25%) ⬆️
src/core/bbr.c 68.10% <80.00%> (-4.32%) ⬇️
src/core/loss_detection.c 89.43% <92.59%> (-0.60%) ⬇️
src/core/connection.c 81.45% <100.00%> (-0.20%) ⬇️
src/core/packet_builder.c 91.82% <100.00%> (ø)
... and 3 more

... and 9 files with indirect coverage changes

docs/Architecture.md Outdated Show resolved Hide resolved
@nibanks nibanks merged commit a42b6b1 into main Sep 11, 2023
429 of 431 checks passed
@nibanks nibanks deleted the nibanks/64-bit-send-time branch September 11, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants