-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Segmentation Support on EIO #3867
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3867 +/- ##
=======================================
Coverage ? 86.44%
=======================================
Files ? 56
Lines ? 16693
Branches ? 0
=======================================
Hits ? 14431
Misses ? 2262
Partials ? 0 |
Interesting. Does Linux GSO not perform software fallback? |
In the case of software UDP GSO, Linux still requires the egress netdev to offload checksumming: https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man7/udp.7?id=806eabd74910447f21005160e90957bde4db0183 |
Description
Update Linux epoll datapath to fallback to non-GSO sends if the
EIO
error is returned, which most likely indicates the NIC doesn't support it. This seems to be the case on at least some Android devices.Fixed #3865.
Testing
CI/CD for regression testing. Not sure how to actually test this fallback atm.
Documentation
N/A