Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leakage of NumaNodeMasks #3882

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

qzhuyan
Copy link
Contributor

@qzhuyan qzhuyan commented Sep 26, 2023

Description

fix a NumaNodeMasks leakage.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

N/A

@qzhuyan qzhuyan requested a review from a team as a code owner September 26, 2023 18:56
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I don't know how I missed this when I added the code originally!

@nibanks nibanks added OS: Ubuntu Bug: Platform A code bug in platform/TLS specific code. labels Sep 26, 2023
@qzhuyan
Copy link
Contributor Author

qzhuyan commented Sep 26, 2023

No rush.

I am checking if it is ok to free since it is used by pthread_setaffinity_np

Thanks for the fix! I don't know how I missed this when I added the code originally!

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f9d26ac). Click here to learn what that means.
Report is 10 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3882   +/-   ##
=======================================
  Coverage        ?   86.42%           
=======================================
  Files           ?       56           
  Lines           ?    16693           
  Branches        ?        0           
=======================================
  Hits            ?    14427           
  Misses          ?     2266           
  Partials        ?        0           

@nibanks nibanks merged commit 73a11d7 into microsoft:main Sep 27, 2023
383 of 385 checks passed
@qzhuyan qzhuyan deleted the fix/william/memleak-NumaNodeMasks branch September 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Platform A code bug in platform/TLS specific code. OS: Ubuntu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants