Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Internal Build Referencing Preview Features #3982

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Dec 3, 2023

Description

Internal build doesn't use preview features for tests. The code needs to account for this at build time.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner December 3, 2023 15:35
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67ce5af) 87.17% compared to head (e8c5a8b) 86.04%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3982      +/-   ##
==========================================
- Coverage   87.17%   86.04%   -1.14%     
==========================================
  Files          56       56              
  Lines       16958    16957       -1     
==========================================
- Hits        14783    14590     -193     
- Misses       2175     2367     +192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ProjectsByJackHe ProjectsByJackHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like changes are adding the guards to prevent Preview Feature tests to run if QUIC_API_ENABLE_PREVIEW_FEATURES features are not defined.

LGTM!

@nibanks nibanks merged commit 3861a76 into main Dec 4, 2023
396 of 398 checks passed
@nibanks nibanks deleted the nibanks/fix-internal-build branch December 4, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants