Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile static library may failed by linking dl.a #4030

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

st-jliu
Copy link
Contributor

@st-jliu st-jliu commented Dec 28, 2023

Description

Compile as static library in Ubuntu 22.04 LTS, may failed by try linking with dl.a, skip the dependency just like Threads::Threads can fix this issue

Resolved issue #3989

@st-jliu st-jliu requested a review from a team as a code owner December 28, 2023 02:11
@nibanks nibanks added Area: Build external Proposed by non-MSFT labels Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a11b58b) 86.17% compared to head (13f1c29) 86.69%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4030      +/-   ##
==========================================
+ Coverage   86.17%   86.69%   +0.51%     
==========================================
  Files          56       56              
  Lines       16953    16953              
==========================================
+ Hits        14610    14698      +88     
+ Misses       2343     2255      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit c4a5a38 into microsoft:main Dec 30, 2023
395 of 397 checks passed
@st-jliu st-jliu deleted the b_libdl branch January 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants