Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream blockedtimings stats initialization #4046

Merged

Conversation

jarnovanderlinden
Copy link
Contributor

@jarnovanderlinden jarnovanderlinden commented Jan 10, 2024

Description

Fix for stream blockedtimings stats intialization. Closes #4044.
Just a matter of ensuring the correct parts of the expression are used for the ternary operator condition.

@jarnovanderlinden jarnovanderlinden requested a review from a team as a code owner January 10, 2024 02:08
@jarnovanderlinden
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Vizrt, Inc."

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (878886a) 87.08% compared to head (0d12869) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
- Coverage   87.08%   86.23%   -0.86%     
==========================================
  Files          56       56              
  Lines       16938    16938              
==========================================
- Hits        14751    14606     -145     
- Misses       2187     2332     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks added Bug: Core A code bug in the Core MsQuic code external Proposed by non-MSFT Area: Core Related to the shared, core protocol logic labels Jan 10, 2024
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

@nibanks nibanks merged commit 6e4cdc9 into microsoft:main Jan 10, 2024
353 of 355 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic Bug: Core A code bug in the Core MsQuic code external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream blocked timings stats incorrectly initialized
2 participants