Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Schannel Logic to Handler Larger Output Buffers #4083

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Jan 26, 2024

Description

A user reported an issue with the schannel variant of MsQuic sometimes not working, and it was an issue with too large of output buffers. This change updates the code to dynamically increase the buffer size as necessary.

Note - We might want to backport this.

Testing

Updated a test to exercise the new code paths.

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner January 26, 2024 13:21
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4778465) 87.25% compared to head (953811a) 87.15%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4083      +/-   ##
==========================================
- Coverage   87.25%   87.15%   -0.11%     
==========================================
  Files          56       56              
  Lines       16938    16983      +45     
==========================================
+ Hits        14780    14801      +21     
- Misses       2158     2182      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if (Enabled) {
Type = PRIVATE_TP_TYPE;
Length = PRIVATE_TP_LENGTH;
Buffer = new(std::nothrow) uint8_t[PRIVATE_TP_LENGTH];
Length = Resumption ? PRIVATE_TP_LENGTH : PRIVATE_TP_LENGTH_HUGE;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must do this because increasing the size increases the chance that 0-RTT doesn't work in the face of random packet loss.

@nibanks nibanks merged commit a6b8120 into main Jan 26, 2024
346 of 361 checks passed
@nibanks nibanks deleted the nibanks/big-tls-output branch January 26, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants