Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another Try at Fixing the Long Event #4105

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Another Try at Fixing the Long Event #4105

merged 1 commit into from
Feb 5, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Feb 3, 2024

Description

Previous change seems to be causing kernel crashes. Undo that and fix individual event.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

Is there any documentation impact for this change?

@nibanks nibanks requested a review from a team as a code owner February 3, 2024 15:48
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86e08e5) 87.38% compared to head (74a2d92) 86.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4105      +/-   ##
==========================================
- Coverage   87.38%   86.35%   -1.03%     
==========================================
  Files          56       56              
  Lines       16984    16984              
==========================================
- Hits        14841    14667     -174     
- Misses       2143     2317     +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks enabled auto-merge (squash) February 3, 2024 20:10
@nibanks nibanks merged commit b1fe28b into main Feb 5, 2024
358 of 370 checks passed
@nibanks nibanks deleted the nibanks/fix-event branch February 5, 2024 18:57
nibanks added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants