Fix Possible DISPATCH_SEND Inline Issue #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
Bug: Core
csujedihy
reviewed
Feb 6, 2024
|
We have the same inline execution for other APIs like StreamClose and ConnectionClose. Should we change them as well? |
No, because *Close functions are required to be called at PASSIVE_LEVEL. |
csujedihy
previously approved these changes
Feb 6, 2024
csujedihy
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've seen indication of a possible issue when sending at DISPATCH_LEVEL, so we're fixing the behavior to always queue in these cases (no inline execution).
Testing
Updated some tests to send at DISPATCH_LEVEL in kernel.
Documentation
N/A