Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HPS test on WSK #4440

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix HPS test on WSK #4440

merged 2 commits into from
Aug 7, 2024

Conversation

ProjectsByJackHe
Copy link
Contributor

Description

Right now, we are skipping all HPS tests on kernel mode msquic.

Let's enable it, and use netperf to figure out whether or not we have a bug somewhere.

Testing

CI

Documentation

N/A

@ProjectsByJackHe ProjectsByJackHe requested a review from a team as a code owner August 7, 2024 19:45
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (b4d79a3) to head (ccd8842).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4440      +/-   ##
==========================================
- Coverage   86.14%   85.79%   -0.35%     
==========================================
  Files          56       56              
  Lines       15508    15508              
==========================================
- Hits        13359    13305      -54     
- Misses       2149     2203      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ProjectsByJackHe
Copy link
Contributor Author

https://github.com/microsoft/netperf/actions/runs/10290765002
and
https://github.com/microsoft/netperf/actions/runs/10291798946/job/28485145126

both works on WSK (HPS test).

Once we merge this, let's be on the look out for any future failures.

@ProjectsByJackHe ProjectsByJackHe enabled auto-merge (squash) August 7, 2024 22:01
@ProjectsByJackHe ProjectsByJackHe merged commit caba7bb into main Aug 7, 2024
450 of 452 checks passed
@ProjectsByJackHe ProjectsByJackHe deleted the jackhe/diagnose-secnet-bugs branch August 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants