Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more AE tests and updated AE properties to not read from env variable #1186

Merged
merged 65 commits into from
Nov 29, 2019

Conversation

lilgreenbird
Copy link
Member

No description provided.

@lilgreenbird lilgreenbird changed the title more AE tests and updated AE properties not not read from env variable more AE tests and updated AE properties to not read from env variable Nov 19, 2019
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1186 into dev will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1186      +/-   ##
============================================
+ Coverage     55.85%   56.59%   +0.73%     
- Complexity     3550     3643      +93     
============================================
  Files           130      130              
  Lines         29332    29332              
  Branches       4855     4855              
============================================
+ Hits          16383    16599     +216     
+ Misses        10626    10417     -209     
+ Partials       2323     2316       -7
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (-1.3%) 112% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.71% <0%> (-0.72%) 35% <0%> (-1%)
...ft/sqlserver/jdbc/SQLServerVSMEnclaveProvider.java 80.39% <0%> (-0.34%) 27% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.22%) 43% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.62% <0%> (+0.06%) 256% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 62.23% <0%> (+0.09%) 0% <0%> (ø) ⬇️
...crosoft/sqlserver/jdbc/KeyStoreProviderCommon.java 64.38% <0%> (+1.36%) 10% <0%> (+1%) ⬆️
...SQLServerColumnEncryptionJavaKeyStoreProvider.java 78.52% <0%> (+11.65%) 21% <0%> (+5%) ⬆️
...m/microsoft/sqlserver/jdbc/KeyVaultCredential.java 84.37% <0%> (+15.62%) 4% <0%> (+2%) ⬆️
...QLServerColumnEncryptionAzureKeyVaultProvider.java 73.02% <0%> (+21.39%) 27% <0%> (+13%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb3f12...625fb70. Read the comment docs.

@ulvii ulvii added this to the 8.1.1 milestone Nov 20, 2019
peterbae
peterbae previously approved these changes Nov 21, 2019
rene-ye
rene-ye previously approved these changes Nov 22, 2019
@lilgreenbird lilgreenbird merged commit ca395b0 into microsoft:dev Nov 29, 2019
ulvii pushed a commit that referenced this pull request Mar 3, 2020
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants